578754 - TP notification window is not readable

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Description

[Jinghua zhang]

"New Test Pilot Survey" popped up, but I'm unable to read the rest of it because it's white text on a very light background.

Comment 1

[Jinghua zhang]

"the bubble with the test pilot study was unreadable- white text on white background is just invisible"

This has been reported several time from users and we couldn't reproduce it. Tracy, could you help us verify it? It may related to browser settings.

Comment 2

[Jinghua zhang]

As mentioned by Faaborg, this case should only happens with Windows XP users that use Classic theme.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

well, that was a guess.  Either way we need to get the new panel UI landed and tested so that this won't be an issue.

Comment 4

[Jinghua zhang]

Finally we got the screenshot for this issue:
http://twitpic.com/28xrx4

Its Windows 7 with Aero enabled and Firefox 4 b1.

Comment 5

[Jono Xia]

I notice in that screenshot that the user has a Persona installed that sets all the title bar / tab bar text to white... I'm guessing there's a CSS style rule that is also being applied to the text in the notification window?

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

>I notice in that screenshot that the user has a Persona installed that sets all
>the title bar / tab bar text to white...

yeah, it's the persona causing it

Comment 7

[Jinghua zhang]

Good to know that we find out the root problem. I believe Jono has already had a solution in mind. :)

Comment 8

[Andres Hernandez [:andreshm]]

Attachment: proposed patch

The color of the popup was enforzed to be -moz-dialogtext. This way, when a persona changes the color of the window to another color, it won't affect the popup.

Comment 9

[Jono Xia]

Hi Andres,

Shouldn't the change be made to the Windows-specific CSS file (extension/skin/win/feedback.css) instead of the general browser.css?  The Mac version has white text on dark grey background, so we don't want to enforce moz-dialogtext color there, only on Windows.

Comment 10

[Andres Hernandez [:andreshm]]

Attachment: patch fix

Moved the change to the specific css style.

Comment 11

[Jono Xia]

OK, fix is verified on my Win 7 box, also verified that it doesn't change text color on my Mac.  I merged the patch into Hg repo in http://hg.mozilla.org/labs/testpilot/rev/8805b71d2486

Needs review for inclusion in Fx4b4.

Comment 12

[Tracy Walker [:tracy]]

Notifications are already covered in Litmus.

Comment 13

[Dave Townsend [:mossop]]

Comment on attachment 462812 [details] [diff] [review]
patch fix

It is just this patch that is needed right? Not the other one?

Comment 14

[Jono Xia]

That's right.

Comment 15

[Dave Townsend [:mossop]]

Attachment: patch for mozilla-central

Comment 16

[Dave Townsend [:mossop]]

Attachment: patch for mozilla-central

This is the right patch for mozilla-central

Comment 17

[[e-mail]]

http://hg.mozilla.org/projects/electrolysis/rev/f3d4f656d439