578919 - SUTAgentAndroid hangs sending test package to tegra

Status: RESOLVED FIXED

Description

[Mike Taylor [:bear]]

Created attachment 457510 [details]
output from the SUTAgentAndroid info command

running the install.py helper script and the push command hangs.  Using a version of SUTAgentAndroid that was built from trunk and installed using adb

below is the command, attached is the output from the "info" agent command

moz:talosscripts bear$ python install.py 192.168.42.105 ~/Downloads/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip 
connecting to: 192.168.42.105
reconnecting socket
send cmd: cd /tests

recv'ing...
send cmd: cwd

recv'ing...
in push file with: /Users/bear/Downloads/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip, and: /tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip
send cmd: hash /tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip

recv'ing...
remote hash returned: 'Couldn't calculate hash for file /tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip'
local hash returned: 'ab055fb7dc452ccf5eaa4129f1116d8b'
send cmd: mkdr /tests

recv'ing...
sending: push /tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip
send cmd: push /tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip 35028480

Comment 1

[Mike Taylor [:bear]]

I looked to t

Comment 2

[Joel Maher ( :jmaher ) (UTC-4)]

I know we have tweaked the push command a lot with this android agent, but I am under the impression that it is pretty stable...I am not ruling it out all the way yet.

One thing to consider is we have removed the overall concept of /tests.  Historically we were going to make an assumption that '/tests' would exist and if it didn't the agent would magically work around it.  This was causing confusion and debugging headaches, so we decided to switch to a more accurate deviceroot api call that we could use.

I think all the install, cleanup, reboot scripts need to be adjusted for this.

It could be as simple as this:
dm = DeviceManager(ip, port)
devRoot = dm.getDeviceRoot()
dm.pushFile(filename, devRoot + '/' + filename.split('/')[-1])


Simply replace all instances of '/tests' with 'devRoot'.

Comment 3

[Mike Taylor [:bear]]

realized that the talos test environment I was using may not have all of the devicemanager.py changes you have done recently, so I copied over from the remote-testing repo a fresh copy.  

That looks like it gets further but still hangs at the very end:

moz:talosscripts bear$ python install.py 192.168.42.105 ~/Downloads/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip 
connecting to: 192.168.42.105
reconnecting socket
in push file with: /Users/bear/Downloads/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip, and: /data/data/com.mozilla.SUTAgentAndroid/files/tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip
remote hash returned: 'Couldn't calculate hash for file /data/data/com.mozilla.SUTAgentAndroid/files/tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip'
local hash returned: 'ab055fb7dc452ccf5eaa4129f1116d8b'
sending: push /data/data/com.mozilla.SUTAgentAndroid/files/tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip
local hash returned: 'ab055fb7dc452ccf5eaa4129f1116d8b'
push returned ab055fb7dc452ccf5eaa4129f1116d8b
It worked

Comment 4

[Mike Taylor [:bear]]

here is the output with devicemanager's debug level set to 5:

moz:talosscripts bear$ python install.py 192.168.42.105 ~/Downloads/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip 
connecting to: 192.168.42.105
reconnecting socket
send cmd: cd /data/data/com.mozilla.SUTAgentAndroid/files/tests

recv'ing...
send cmd: cwd

recv'ing...
in push file with: /Users/bear/Downloads/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip, and: /data/data/com.mozilla.SUTAgentAndroid/files/tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip
send cmd: hash /data/data/com.mozilla.SUTAgentAndroid/files/tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip

recv'ing...
remote hash returned: 'ab055fb7dc452ccf5eaa4129f1116d8b'
local hash returned: 'ab055fb7dc452ccf5eaa4129f1116d8b'
files are validated
send cmd: cd /data/data/com.mozilla.SUTAgentAndroid/files/tests

recv'ing...
send cmd: cwd

recv'ing...
send cmd: cd /data/data/com.mozilla.SUTAgentAndroid/files/tests

recv'ing...
send cmd: ls

recv'ing...
send cmd: cd /data/data/com.mozilla.SUTAgentAndroid/files/tests

recv'ing...
send cmd: unzp /data/data/com.mozilla.SUTAgentAndroid/files/tests/fennec-2.0a1pre.multi.linux-gnueabi-arm.tests.zip

recv'ing...

Comment 5

[Mike Taylor [:bear]]

while running it again to verify, I got distracted and when I looked at terminal it had finished - seems the unpack step was just *very* slow.

Comment 6

[Joel Maher ( :jmaher ) (UTC-4)]

so can we close this bug?

Comment 7

[Mike Taylor [:bear]]

yep