Closed Bug 579175 Opened 14 years ago Closed 14 years ago

services/sync ignored in filter.py

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(blocking2.0 beta3+)

RESOLVED FIXED
mozilla4.0b3
Tracking Status
blocking2.0 --- beta3+

People

(Reporter: Pike, Assigned: Pike)

References

Details

Attachments

(1 file)

When landing bug 571902, we missed adding services/sync to the list of directories that matter in filter.py.

Thus compare-locales isn't reporting on those strings, and it's not triggering l10n-merge either.

Bad me for not checking that things look right at the right time.
Benjamin, I wouldn't know someone less off, and you've had this on your mind just a few ago.

See bug 571902 comment 84 about my question on whether we should actually bother disabling services/sync in browser/locales/Makefile.in or if that's going to be just on in a few anyway.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Attachment #457685 - Flags: review?
Attachment #457685 - Flags: review? → review?(benjamin)
Attachment #457685 - Flags: review?(benjamin) → review+
Depends on: 571897
We need services/sync to actually show up in compare-locales and the build.

PS: services/sync/locales/en-US is identical to weave-l10n/en-US, for which we already have a ton of localizations :-)
blocking2.0: --- → ?
blocking2.0: ? → beta3+
And FIXED, http://hg.mozilla.org/mozilla-central/rev/c5f35032f22d.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
Blocks: 632922
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 4.0b3 → mozilla4.0b3
You need to log in before you can comment on or make changes to this bug.