579185 - Update talos helper scripts to work with new SUTAgentAndroid

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Mike Taylor [:bear]]

Attached are the helper scripts needed to drive SUTAgentAndroid from a talos build slave

Comment 1

[Mike Taylor [:bear]]

Attachment: helper scripts to drive SUTAgentAndroid

devicemanager.py, hashlib.py and dvTestWrapper.py are all from remote-testing repo but they should be merged into m-c soon

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 457684 [details] [diff] [review]
helper scripts to drive SUTAgentAndroid

Not an in-depth line-by-line review, by any means.

Some questions:

* Are we going to have 3+ devicemanager.py's floating around? (m-c + project branches, talos, build/tools/sut/ ?)
* I'm gonna guess you copied it, right? Trailing whitespace always bugs me, but if we have multiple copies we don't want to have to deal with the whitespace diff.
* Is it kosher checking hashlib.py into our repo? (yeah, I dunno either)
* what's dvTestWrapper.py for? Any usage readme?

Overall I'm ready to rubber stamp it, but we should clear up the above.

Comment 3

[Mike Taylor [:bear]]

(In reply to comment #2)
> Comment on attachment 457684 [details] [diff] [review]
> helper scripts to drive SUTAgentAndroid
> 
> Not an in-depth line-by-line review, by any means.
> 
> Some questions:
> 
> * Are we going to have 3+ devicemanager.py's floating around? (m-c + project
> branches, talos, build/tools/sut/ ?)

I was going to ask the ateam that question also - it would seem that we should move it to a tools dir since now it will be common to all ateam usage

> * I'm gonna guess you copied it, right? Trailing whitespace always bugs me, but
> if we have multiple copies we don't want to have to deal with the whitespace
> diff.

oh yea, copied for sure and I had to force myself to ignore the whitespace issues

> * Is it kosher checking hashlib.py into our repo? (yeah, I dunno either)
> * what's dvTestWrapper.py for? Any usage readme?

good question about hashlib, I was assuming it was a Moz util but reading it I realize it looks like a very early version of what is now in Python v3 - I'll ask ateam

dvTestWrapper looks like it just came along for the ride, earlier code I had seen in the remote-testing repo was using it but looking deeper at devicemanager.py is making me think no.

> 
> Overall I'm ready to rubber stamp it, but we should clear up the above.

Comment 4

[Mike Taylor [:bear]]

Attachment: helper scripts to drive SUTAgentAndroid

reworked patch to remove dvTestWrapper.py and hashlib.py - not required for our use

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 457735 [details] [diff] [review]
helper scripts to drive SUTAgentAndroid

*stamp*
We can, and should, haggle about the "official" location[s] of devicemanager.py later.

Comment 6

[Mike Taylor [:bear]]

files checked in to /build/tools/sut_tools as changeset 676bdebb589f