579334 - Async visits are ignoring a disabled history

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

Async visits are using canAddURI but it does not check isHistoryDisabled.

Comment 1

[Marco Bonardo [:mak]]

should block beta2

Comment 2

[Dietrich Ayala (:dietrich)]

Privacy exposure, marking blocking.

Comment 3

[Marco Bonardo [:mak]]

Attachment: patch v1.0

I put this up pretty quickly, will need a tryserver run and more eyes.
Tests are mostly a partial copy of the existing one.
Getting feedback from Benjamin, he said he ad ideas for an orange we saw, so let's see if our ideas could be similar.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

If this is going to make beta 2, it'll have to be reviewed and checked in by end of day today. Is that likely to happen?

Comment 5

[Marco Bonardo [:mak]]

tryserver run was fine, so I'm positive we can do that.

Comment 6

[Shawn Wilsher :sdwilsh]

(In reply to comment #4)
> If this is going to make beta 2, it'll have to be reviewed and checked in by
> end of day today. Is that likely to happen?
If you believe in magic (of the speedy review kind) :)

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 457922 [details] [diff] [review]
patch v1.0

>+++ b/toolkit/components/places/tests/browser/Makefile.in
>@@ -48,6 +48,8 @@ include $(topsrcdir)/config/rules.mk
> _BROWSER_FILES = \
> 	browser_bug399606.js \
> 	browser_visituri.js \
>+  browser_visituri_nohistory.js \
>+  browser_visituri_privatebrowsing.js \
> 	browser_settitle.js \
> 	$(NULL)
nit: tabs before, now spaces.  Just be consistent (don't care which way you want to go)

>+++ b/toolkit/components/places/tests/browser/browser_visituri_nohistory.js
>+function waitForClearHistory(aCallback) {
nit: brace on new line (like every other function you declare)

>+++ b/toolkit/components/places/tests/browser/browser_visituri_privatebrowsing.js
>+function waitForClearHistory(aCallback) {
nit: brace on new line (like every other function you declare)

r=sdwilsh

Comment 8

[Marco Bonardo [:mak]]

Attachment: patch v1.1

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/7a697c59e0e4