579505 - order of items on the add-on bar should be persistent

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

because the items are added after the point at which toolbars use xul's persistence mechanism, it's not likely we can hook in that way as is.

we could modify xul toolbars to support late-re-ordering somehow.

or we could modify the widget impl to track ids on the bar, and find each widget's proper position. this would require a whole bunch of fragile assumptions though (add-on load order, unchanging item ids, unchanging set of addons).

not sure how to proceed. this is a P2 now though, doesn't have to block moving forward.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 2

[Alexandre Poirot [:ochameau]]

Pull request 118 fixed that bug by adding a new widget.id attribute and restoring widget in previous toolbar and previous position:
https://github.com/mozilla/addon-sdk/commit/e2b1538c0ad4d408affaa2ca37f072af7b07a4c0#L4L421