579636 - Show search loading message when waiting for AMO search to finish, and no local add-ons were found

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ben Parr [:bparr]]

The search for local add-ons usually finishes before the AMO search finishes. So, if no local add-ons are found, the search results list is completely blank while the AMO search finishes. The search throbber is showing until both the local search and AMO search finish. However, we may want an additional loading message to avoid the completely blank search results list.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Does that mean we show local add-ons immediately once the local search has been finished? If yes, do we resort all entries when we also have found remote add-ons? Or will we put those into two different groups?

Even with local add-ons found and waiting for results from AMO we should have a visual indicator. Given the usage of different groups it would be easy to add such a temporary list entry which says "Search on AMO for add-ons..." or similar.

I think it's a good question for UX. Boriss?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Done as part of my work on bug 601022 - made it the same as all the other loading indicators we have.

Comment 3

[Dave Townsend [:mossop]]

Fixed by bug 601022

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away July 24th - August 16th)]

Verified fixed on all platforms with builds like Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101124 Firefox/4.0b8pre

Do we already have an automated test for?

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Yes.