579649 - Update Hunspell to 1.2.12

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Hunspell 1.2.12 is out. It is a very minor update from 1.2.11 (it's mostly fixes that already landed on our tree after 1.2.11 landed).

Fixes are:
-Bug 525581 (already on trunk and 1.9.2)
-Bug 569611
-Bug 571728 (already on trunk)
-Fix COMPOUNDRULE parsing for parenthesized flags

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Trunk patch

Comment 2

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/74c2b98ebb48

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: 3.6 roll-up patch

This is a roll-up patch for the 3.6 branch. It fully updates from Hunspell 1.2.8 to 1.2.12, which has shipped in a couple beta releases off trunk now with no known issues. It fixes many memory leaks found by Coverity and Valgrind along with other bugs (see bug 564608 and its dependencies for more info).

It also includes the fix for the low-risk bug 583582 to fix compiling with gcc 4.5. If approved on this bug, the approval request on that bug can be disregarded.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 489319 [details] [diff] [review]
3.6 roll-up patch

Don't know what I was smoking on that request...

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 489319 [details] [diff] [review]
3.6 roll-up patch

Since we have limited nightly user tested (and dropping as FF4 sucks away more of the early-adopter crowd) we'd rather land this at the beginning of 1.9.2.14 instead of in the last week of 1.9.2.13. Minusing for now, please request approval for the next release when we create those flags.

Comment 6

[LegNeato]

Comment on attachment 489319 [details] [diff] [review]
3.6 roll-up patch

a=LegNeato for 1.9.2.14.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/30ed993d324c

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> http://hg.mozilla.org/releases/mozilla-1.9.2/rev/30ed993d324c

Backed out, patch doesn't build.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

The patch accidentally picked up some changes to mozHunspellDirProvider.{cpp|h} that it shouldn't have. Dao, if you want to remove those changes and re-push, it should build OK. Otherwise, I'll post a new patch. I won't be able to get to it until tomorrow, though.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Attachment: 3.6 roll-up patch v2

Now without the spurious changes noted in comment #9. Does this need re-approval or can it carry over?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Attachment: 3.6 roll-up patch v2a

I found one other change nearly slipped in. I've completely audited this patch to ensure that there are no other inadvertent changes included. I apologize for all the churn and bugspam.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Are we reopening bugs for branch landings now? This has been fixed on trunk for 5 months.

Comment 13

[LegNeato]

Nope, sorry. Totally spaced :-)

Comment 14

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/afadbba2ae5f