Closed Bug 579649 Opened 13 years ago Closed 13 years ago

Update Hunspell to 1.2.12


(Core :: Spelling checker, defect)

Not set



Tracking Status
status1.9.2 --- .14-fixed


(Reporter: RyanVM, Assigned: RyanVM)




(2 files, 2 obsolete files)

Hunspell 1.2.12 is out. It is a very minor update from 1.2.11 (it's mostly fixes that already landed on our tree after 1.2.11 landed).

Fixes are:
-Bug 525581 (already on trunk and 1.9.2)
-Bug 569611
-Bug 571728 (already on trunk)
-Fix COMPOUNDRULE parsing for parenthesized flags
Attached patch Trunk patchSplinter Review
Attachment #458091 - Flags: review?(Olli.Pettay)
Attachment #458091 - Flags: review?(Olli.Pettay) → review+
Keywords: checkin-needed
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Attached patch 3.6 roll-up patch (obsolete) — Splinter Review
This is a roll-up patch for the 3.6 branch. It fully updates from Hunspell 1.2.8 to 1.2.12, which has shipped in a couple beta releases off trunk now with no known issues. It fixes many memory leaks found by Coverity and Valgrind along with other bugs (see bug 564608 and its dependencies for more info).

It also includes the fix for the low-risk bug 583582 to fix compiling with gcc 4.5. If approved on this bug, the approval request on that bug can be disregarded.
Attachment #489319 - Flags: approval2.0?
Comment on attachment 489319 [details] [diff] [review]
3.6 roll-up patch

Don't know what I was smoking on that request...
Attachment #489319 - Flags: approval2.0? → approval1.9.2.13?
Comment on attachment 489319 [details] [diff] [review]
3.6 roll-up patch

Since we have limited nightly user tested (and dropping as FF4 sucks away more of the early-adopter crowd) we'd rather land this at the beginning of instead of in the last week of Minusing for now, please request approval for the next release when we create those flags.
Attachment #489319 - Flags: approval1.9.2.13? → approval1.9.2.13-
Attachment #489319 - Flags: approval1.9.2.14?
Comment on attachment 489319 [details] [diff] [review]
3.6 roll-up patch

a=LegNeato for
Attachment #489319 - Flags: approval1.9.2.14? → approval1.9.2.14+
Keywords: checkin-needed
The patch accidentally picked up some changes to mozHunspellDirProvider.{cpp|h} that it shouldn't have. Dao, if you want to remove those changes and re-push, it should build OK. Otherwise, I'll post a new patch. I won't be able to get to it until tomorrow, though.
Attached patch 3.6 roll-up patch v2 (obsolete) — Splinter Review
Now without the spurious changes noted in comment #9. Does this need re-approval or can it carry over?
Attachment #489319 - Attachment is obsolete: true
I found one other change nearly slipped in. I've completely audited this patch to ensure that there are no other inadvertent changes included. I apologize for all the churn and bugspam.
Attachment #499546 - Attachment is obsolete: true
Attachment #499550 - Flags: approval1.9.2.14+
Attachment #489319 - Flags: approval1.9.2.14+ → approval1.9.2.14-
Resolution: FIXED → ---
Are we reopening bugs for branch landings now? This has been fixed on trunk for 5 months.
Keywords: checkin-needed
Nope, sorry. Totally spaced :-)
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.