579793 - Shark builds broken ('class js::Value' has no member named 'isFunObj')

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Worked at 3:30am PDT on the 14th, fails the same time a day later. Regression window:
http://hg.mozilla.org/tracemonkey/pushloghtml?fromchange=6214ca8c0e7e&tochange=9c869e64ee26
Fallout from bug 549143 ?

The are errors building jsbool and jsatom like this:
In file included from /builds/slave/tracemonkey-macosx-shark/build/js/src/jsobjinlines.h:52,
                 from /builds/slave/tracemonkey-macosx-shark/build/js/src/jsbool.cpp:57:
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsdtracef.h: In static member function 'static void js::DTrace::enterJSFun(JSContext*, JSStackFrame*, JSFunction*, JSStackFrame*, jsuint, js::Value*, js::Value*)':
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsdtracef.h:100: error: 'class js::Value' has no member named 'isFunObj'
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsdtracef.h: In static member function 'static void js::DTrace::exitJSFun(JSContext*, JSStackFrame*, JSFunction*, const js::Value&, js::Value*)':
/builds/slave/tracemonkey-macosx-shark/build/js/src/jsdtracef.h:116: error: 'class js::Value' has no member named 'isFunObj'

Build log:
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1279449126.1279449877.20154.gz

Comment 1

[Luke Wagner [:luke]]

Ah, I got dtrace building right before removing the fun-obj/non-fun-obj distinction from js::Value.  Tiny fix piggybacked on:

http://hg.mozilla.org/tracemonkey/rev/abc227b2380f