Use "macosx64" instead of "macosx-snow" in buildbot-configs

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 458265 [details] [diff] [review]
Use "macosx64" instead of "macosx-snow" in buildbot-configs

Using "macosx-snow" for slave names introduces duplication of code (see bug 578749 comment #10). It will be better to use the same name as we use for the platforms.
Attachment #458265 - Flags: review?(bear)

Updated

8 years ago
Attachment #458265 - Flags: review?(bear) → review+
I'd argue that "macosx64" is incorrect, actually. The uname of these machines is "i386", not "x86_64".

Comment 2

8 years ago
(In reply to comment #1)
> I'd argue that "macosx64" is incorrect, actually. The uname of these machines
> is "i386", not "x86_64".

The uname is i386 true, but that doesn't convey that they can be used for 64bit builds because of the OS installed - IMO
IMHO slave names should represent the operating system, not what their capable of doing.

Comment 4

8 years ago
(In reply to comment #3)
> IMHO slave names should represent the operating system, not what their capable
> of doing.

I agree with that, but I thought that Rail's change was just to bring the osx64 dictionary key names in line with the others and doesn't impact slave names.  the pattern until "snow" had been foo32 and foo64

sorry if my earlier reply was confusing/misleading - I should have stayed out of the bug queue until later when I could properly focus on it
Sorry, when I say "slave name" I'm speaking of both the hostnames as well as the BuildSlave "slavenames".

32 and 64 are appropriate for the linuxes, because they are indeed 32 and 64-bit host platforms. Same thing for Windows. I'm aware that we used "mac64" in a couple of other places but IMHO we should fix those rather than this.

Comment 6

8 years ago
then i'll change my r+ to a r- and ask Rail if he doesn't mind doing that

+1 ?

Comment 7

8 years ago
Comment on attachment 458265 [details] [diff] [review]
Use "macosx64" instead of "macosx-snow" in buildbot-configs

see thread above for reason why I changed :)
Attachment #458265 - Flags: review+ → review-
We talked about this a bit on the phone. My feelings on this matter aren't very strong, you can land this as far as I'm concerned.
(Assignee)

Comment 9

8 years ago
I'd be happy if we land it, because we need it for mac64 l10n nightlies.
(Assignee)

Comment 10

8 years ago
Created attachment 459134 [details] [diff] [review]
Use "macosx64" instead of "macosx-snow" in buildbot-configs

Refreshed patch.
Attachment #458265 - Attachment is obsolete: true
Attachment #459134 - Flags: review?(bhearsum)
Attachment #459134 - Flags: review?(bhearsum) → review+
(Assignee)

Updated

8 years ago
Blocks: 579092
(Assignee)

Comment 11

8 years ago
Comment on attachment 459134 [details] [diff] [review]
Use "macosx64" instead of "macosx-snow" in buildbot-configs

http://hg.mozilla.org/build/buildbot-configs/rev/04ed26127a9b
Attachment #459134 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.