579837 - Context menu styling in about:sync-tabs is broken

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[ahoza]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre
Build Identifier: 

For Windows 7 it has a transparent background and for Mac 10.6 the separator is not displayed properly

Reproducible: Always

Steps to Reproduce:
Environment:

Client A: Win7(32), Mozilla/5.0 (Windows; Intel Mac OS X 10.6; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre
Client B: Mac 10.6, Mozilla/5.0 (Macintosh; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre
Firefox Sync: 1.4.1

1. Open a few tabs on Client A and sync.
2. Sync on Client B.
3. Open History-> Tabs from other computers and right click in the opened page. 
Actual Results:  
Menu is not displayed properly. See attached screenshots. 

Expected Results:  
Opened menu is displayed properly on both clients (A and B)

Comment 1

[ahoza]

Attachment: Screenshot for Win 7

Comment 2

[ahoza]

Attachment: screenshot for Mac 10.6

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Fix, analogous to zpao's fix in bug 584125.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 462548 [details] [diff] [review]
v1

curious how this will impact addon compat, but... maybe I just suck :)

Comment 5

[Philipp von Weitershausen [:philikon]]

I've verified that this works on Firefox 3.5 and 3.6 as well.

Comment 6

[Philipp von Weitershausen [:philikon]]

1.4.x: http://hg.mozilla.org/services/fx-sync/rev/4ac1699e6a1f
default: http://hg.mozilla.org/services/fx-sync/rev/24e32e70f9c9

Comment 7

[ahoza]

It reproduces again on today's build:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b4pre) Gecko/20100813 Minefield/4.0b4pre

On yesterday's build it looked OK.
Reopening the bug.

Comment 8

[Philipp von Weitershausen [:philikon]]

No, this was fixed in the Sync add-on (fx-sync). I hasn't yet been fixed in the integrated Firefox UI (bug 584125) which is why you're seeing the bug again in today's nightly build (Sync was integrated into Firefox last night).

Comment 9

[Tony Chung [:tchung]]

Verified on Sync 1.4.4 extension