Consider starting bash in its own console window

RESOLVED WONTFIX

Status

mozilla.org
MozillaBuild
RESOLVED WONTFIX
8 years ago
8 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Running bash directly from a batch file has the problem that if you press ^C then when you exit bash CMD asks you if you want to terminate the batch file.
(Assignee)

Comment 1

8 years ago
Created attachment 458303 [details] [diff] [review]
Possible patch
[Backed out: Comment 11]
Attachment #458303 - Flags: review?(ted.mielczarek)
Comment on attachment 458303 [details] [diff] [review]
Possible patch
[Backed out: Comment 11]

Seems reasonable.
Attachment #458303 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → neil
http://hg.mozilla.org/mozilla-build/rev/60498bba9db9
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
This seems to make it impossible to use applications such as Console2, which wrap Windows' console window in its own UI, to provide things like a tabbed interface. Forcing a new command window to open means it can't be displayed in a tab.
Scrolling and maximising is broken too.
Guess we should back it out.
Ha, just found this after finally tracking down why Console2 stopped working last time I updated mozilla-build. Sigh. Would be nice if the start-*.bat scripts could automatically notice they were running inside Console2, but I don't see any obvious way to do such a thing.
Does this mean we are going to back it out?
I keep lacking in time to do so, but anyone else is welcome to back it out.
Hmm, I guess I should have told you, I found out about this myself shortly after it was checked in but didn't take the time to document my findings here. Instead I just fixed it for myself by creating a custom copy of the script.

Maybe we could check an environment variable and make the behavior depend on that? Note that I don't know enough about batch file scripting to implement this, though (bash is so much easier...).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #10)
> Maybe we could check an environment variable and make the behavior depend on
> that?

An env var or a param should be easy to check, if needed.
Eh, doesn't seem worth the time.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → WONTFIX
Attachment #458303 - Attachment description: Possible patch → Possible patch [Backed out: Comment 11]
You need to log in before you can comment on or make changes to this bug.