579860 - Consider starting bash in its own console window

Status: RESOLVED WONTFIX

(Firefox Build System :: MozillaBuild, task)

Description

[[e-mail]]

Running bash directly from a batch file has the problem that if you press ^C then when you exit bash CMD asks you if you want to terminate the batch file.

Comment 1

[[e-mail]]

Attachment: Possible patch [Backed out: Comment 11]

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 458303 [details] [diff] [review]
Possible patch
[Backed out: Comment 11]

Seems reasonable.

Comment 3

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/mozilla-build/rev/60498bba9db9

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

This seems to make it impossible to use applications such as Console2, which wrap Windows' console window in its own UI, to provide things like a tabbed interface. Forcing a new command window to open means it can't be displayed in a tab.

Comment 5

[Mitchell Field [:Mitch]]

Scrolling and maximising is broken too.

Comment 6

[(not currently active) Ted Mielczarek]

Guess we should back it out.

Comment 7

[Justin Dolske [:Dolske]]

Ha, just found this after finally tracking down why Console2 stopped working last time I updated mozilla-build. Sigh. Would be nice if the start-*.bat scripts could automatically notice they were running inside Console2, but I don't see any obvious way to do such a thing.

Comment 8

[Shawn Wilsher :sdwilsh]

Does this mean we are going to back it out?

Comment 9

[(not currently active) Ted Mielczarek]

I keep lacking in time to do so, but anyone else is welcome to back it out.

Comment 10

[Jens Hatlak (:InvisibleSmiley)]

Hmm, I guess I should have told you, I found out about this myself shortly after it was checked in but didn't take the time to document my findings here. Instead I just fixed it for myself by creating a custom copy of the script.

Maybe we could check an environment variable and make the behavior depend on that? Note that I don't know enough about batch file scripting to implement this, though (bash is so much easier...).

Comment 11

[Justin Wood (:Callek)]

http://hg.mozilla.org/mozilla-build/pushloghtml?changeset=60a3d4f23e86

For backout.

Comment 12

[Serge Gautherie (:sgautherie)]

(In reply to comment #10)
> Maybe we could check an environment variable and make the behavior depend on
> that?

An env var or a param should be easy to check, if needed.

Comment 13

[(not currently active) Ted Mielczarek]

Eh, doesn't seem worth the time.