Closed Bug 579879 Opened 14 years ago Closed 14 years ago

Closed App Tab when Restored should be restored to position of where it was before being closed

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 4.0b3
Tracking Flags:
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: Ryuji, Assigned: dao)

References

Details

Attachments

(3 files)

Step 2
241.89 KB, image/png
Details
Step 5
481.65 KB, image/png
Details
patch + test
2.65 KB, patch
dietrich
: review+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre Restoring a closed App tab should restore it back to its tab position before it was closed. However it was not the case, I discovered that it closed its position when restored to the right-most tab. Reproducible: Always Steps to Reproduce: 1. Open a few tabs 2. Make 4 of the tabs into App Tabs 3. Close the first App Tabs by right clink Tab Bar and select Close Tab. 4. Right Clink Tab Bar and select Undo Close 5. Restore App Tab become the most right-most App Tab Now.
Attached image Step 2 —
Attached image Step 5 —
Blocks: pinnedtabs
Component: General → Tabbed Browser
QA Contact: general → tabbed.browser
Version: unspecified → Trunk
Assignee: nobody → dao
Component: Tabbed Browser → Session Restore
OS: Windows 7 → All
QA Contact: tabbed.browser → session.restore
Hardware: x86 → All
Blocks: 575560
No longer blocks: pinnedtabs
Attached patch patch + test — — Splinter Review
tabbrowser doesn't allow moving the tab before pinned tabs as long as itself isn't pinned, so we need to pin it first and move it afterwards.
Attachment #458614 - Flags: review?(dietrich)
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #458614 - Flags: review?(dietrich) → review+
Perhaps unrelated, but I'm seeing that when my app tabs are restored, one tab seems to overlap another.
(In reply to comment #4) > Perhaps unrelated, but I'm seeing that when my app tabs are restored, one tab > seems to overlap another. bug 579868
Bug 579868 - Restoring A Normal Closed Tab that was once a App Tab causes it to turn back into a App tab when restored ?
(In reply to comment #6) > Bug 579868 - Restoring A Normal Closed Tab that was once a App Tab causes it to > turn back into a App tab when restored ? Err, no... There is a bug for your issue, though, I believe.
(In reply to comment #4) > Perhaps unrelated, but I'm seeing that when my app tabs are restored, one tab > seems to overlap another. Bug 579869
Attachment #458614 - Flags: approval2.0?
blocking2.0: --- → betaN+
http://hg.mozilla.org/mozilla-central/rev/0a83bd05d402
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
Verified fixed with 4.0b3build3.
Status: RESOLVED → VERIFIED
Added a test case for this to Litmus: https://litmus.mozilla.org/show_test.cgi?id=12611
Flags: in-litmus+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: