580102 - contrib,contrib-localized being removed from candidates directories

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Both 3.5.11 and 3.6.7 are affected, which blocks Solaris & OS/2 folks. Possibly fallout from bug 342972.

Comment 1

[[e-mail] (:bhearsum)]

Assign to coop based nick's comment and his agreement.

Comment 2

[Chris Cooper [:coop] (he/him)]

I've turned on the verbose flag in rm commands in the crontab so we'll see what it's deleting. The crontabs should be ignore the candidates dirs entirely though.

Comment 3

[Chris Cooper [:coop] (he/him)]

I seriously don't think it was the cleanup scripts. The weekly crontab entries run on Sundays, and the existing contrib dirs for 3.5.11 and 3.6.7 were created in the afternoon on Monday July 19.

Also, there are contrib dirs from 3.6.6 (and 3.6.4 and 3.0.19) that still have builds in them, so this seems fishy to me.

I'll leave the verbose logging on to make sure though.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

This one (ffxbld) doesn't ignore candidates dirs:
@weekly nice -n 19 find /home/ftp/pub/firefox/nightly -depth -empty -type d -exec rmdir -v '{}' \;

Comment 5

[Chris Cooper [:coop] (he/him)]

Oh, I thought the implication was that we had lost files, rather than just losing empty contrib dirs before contributors had uploaded anything. 

Is that what happened here?

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Apart from bug 573879 I don't think we've heard a complaint the Solaris or OS/2 people. Their timing for pushing content into those directories varies a bit so could just be empty dirs getting cleaned up.

Comment 7

[Ginn Chen]

I noticed there was no contrib dir for firefox 3.5.11, 3.6.7, thunderbird 3.0.6, 3.1.1 candidates.
I didn't upload builds yet at that time.

Comment 8

[Chris Cooper [:coop] (he/him)]

(In reply to comment #4)
> This one (ffxbld) doesn't ignore candidates dirs:
> @weekly nice -n 19 find /home/ftp/pub/firefox/nightly -depth -empty -type d
> -exec rmdir -v '{}' \;

I think the solution is to switch to this:

@weekly nice -n 19 find /home/ftp/pub/firefox/nightly -wholename '*-candidates/contrib*' -prune -o -empty -type d -exec rmdir '{}' \;

-prune doesn't work with -depth, so we end up with a little STDERR spam with this, but it's liveable.

Comment 9

[Chris Cooper [:coop] (he/him)]

(In reply to comment #8)
> @weekly nice -n 19 find /home/ftp/pub/firefox/nightly -wholename
> '*-candidates/contrib*' -prune -o -empty -type d -exec rmdir '{}' \;

I've updated all the crontabs to behave as above, and re-added contrib/ dirs to the candidates dirs where they were missing.

Comment 10

[Armen [:armenzg]]

FYI on bug 586230 we are not sure if the contrib directories are being created or if the cleaning scripts might have been cleaned.