Resizing window filled by test plugin does not repaint correctly

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
7 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Posted file Testcase
No description provided.
Comment on attachment 458562 [details] [diff] [review]
fix

>+<embed type="application/x-test" style="width:200px; height:400px;"></embed>

>+<embed type="application/x-test" id="p"
>+       style="position:fixed; width:200px; height:200px;"></embed>

Presumably you intended position fixed on both the reference and the test?
Attachment #458562 - Flags: review?(tnikkel) → review+
Actually I intended *not* to have position:fixed on the reference. They get the same position thanks to left/top being auto.
Whiteboard: [needs landing]
So I guess there are some other places that got view invalidation but now need frame invalidation?
Probably. I fixed a few in bug 564991 itself.
Posted image testcase screenshot
This is what I see before patches.  The black box lines up with the plugin and transparency of the from left to right of the plugin area which i am able to see the background app's left and right vertical borders through firefox.
Actually I suspect this is more of a bug in the test plugin than anything else.

When a windowless plugin's rendering depends on the size of its window, and it detects a change in the window size, it should invalidate itself, right? I don't know of any promise that we make to invalidate a plugin in such a situation. The test plugin doesn't invalidate itself on window size change, but it should.
Whiteboard: [needs landing]
Posted patch fix testplugin (obsolete) — Splinter Review
I think I'm fixing a genuine bug in the test plugin here: in the default drawing mode, when the window size changes we need to redraw the entire window since the text+borders we draw everywhere depends on the window size. (For the solid color mode, this is not true.)

Please correct me if I'm wrong.
Attachment #461974 - Flags: review?(joshmoz)
Posted patch better fixSplinter Review
Attachment #461974 - Attachment is obsolete: true
Attachment #461975 - Flags: review?(joshmoz)
Attachment #461974 - Flags: review?(joshmoz)
Attachment #461975 - Flags: review?(joshmoz) → review+
Comment on attachment 461975 [details] [diff] [review]
better fix

Fix to test plugin only. No risk.
Attachment #461975 - Flags: approval2.0?
Attachment #461975 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/21e82bbf63d2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
The testcase plugin certainly looks fixed now.  I tried to resize it a few times and it does show issues anymore.

Mozilla/5.0 (Windows NT 6.1; rv:2.0b4pre) Gecko/20100808 Minefield/4.0b4pre ID:20100808124602
This bug's testcase seems to be sporadically failing on tinderbox a few times a day -- see bug 611164.
Depends on: 611164
Depends on: 803473
You need to log in before you can comment on or make changes to this bug.