580192 - [D3D9] Accelerated Layers causes fullscreen Ogg Theora video playback to be jagged like and distorted

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[[not reading bugmail]]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b2pre) Gecko/20100719 Minefield/4.0b2pre Glue/4.5
Build Identifier: 

This is a regression between the retain layers landing and tonight, since full screen was not functional because of bug 574778, its hard to say which bug caused this issue. 

my guess its close to 575469.

Reproducible: Always

Steps to Reproduce:
1. Open Ogg Video in the URL
2. Right Click Full screen
3. Watch video mainly showing font rendering or edges/etc.
Actual Results:  
Having mozilla.widget.accelerated-layers = true, video is quite jagged.


Expected Results:  
video looks good just like before, it looks almost the same as normal non fullscreen playback.

Tested turning off Accelerated Layers and the full screen video playback is ok.

Comment 1

[Marcia Knous [:marcia]]

Dale: While testing  Mozilla/5.0 (Windows; Windows NT 5.1; rv:2.0b2) Gecko/20100720 Firefox/4.0b2 I have seen issues while playing http://videos.mozilla.org/firefox/3.6/getpersonas.ogv in full screen. When watching the video in the URL I see the same thing so I am confirming this.

Comment 2

[Bas Schouten (:bas.schouten)]

I'm able to reproduce. Investigating, it seems like we're not setting the MagFilter correctly.

Comment 3

[Bas Schouten (:bas.schouten)]

This is caused by us using the CAIRO_SURFACE fallback path for fullscreen video drawing now. Which doesn't select a linear upsampling filter. We should probably select linear upsampling for all transformed layers which would fix this problem. But the underlying issue of the YUV->RGB accelerated conversion not being used should be fixed as well.

Comment 4

[[not reading bugmail]]

(In reply to comment #3)
> But the underlying issue of the YUV->RGB accelerated conversion
> not being used should be fixed as well.

Does that have anything to do with 577843?

Comment 5

[Bas Schouten (:bas.schouten)]

(In reply to comment #4)
> (In reply to comment #3)
> > But the underlying issue of the YUV->RGB accelerated conversion
> > not being used should be fixed as well.
> 
> Does that have anything to do with 577843?

I don't think so, that bug looks like there was no hardware acceleration at all.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sounds like we're using two different ImageContainers here --- one for the decoder and a different one for rendering, because we're rendering to a different LayerManager than we got in nsHTMLMediaElement. doublec was seeing this too, but for standalone video documents, not the fullscreen document.

Comment 7

[[not reading bugmail]]

Do we need to keep this bug open?  It appears Jimm's patch in bug 579421 took care of it.

Comment 8

[[not reading bugmail]]

Bas, I'm assuming comment 3 still needs to be done anyway.

Comment 9

[Bas Schouten (:bas.schouten)]

(In reply to comment #8)
> Bas, I'm assuming comment 3 still needs to be done anyway.

Yes, there should be a separate bug for it though, I still need to think about it.

Comment 10

[Joshua Mitchell (Inactive)]

Issue is resolved - clearing old keywords - qa-wanted clean-up