580242 - Add a filter textbox in the select helper UI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch add a textbox of type search to filter the result of the select helper UI when it is embedded in the form helper

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Looks pretty nice

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 458658 [details] [diff] [review]
Patch

>diff -r 2a3e2d9bb723 chrome/content/browser-ui.js

>     this._panel.hidden = false;
>+    this._panel.setAttribute("height", this._panel.getBoundingClientRect().height);

>+    this._panel.removeAttribute("height");
>+    this._textbox.value = "";

Why are you using the "height" attribute. Don't we use style.height for other things? or _panel.height =

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/64dbbd01058d(In reply to comment #3)

> Comment on attachment 458658 [details] [diff] [review]
> Patch
> 
> >diff -r 2a3e2d9bb723 chrome/content/browser-ui.js
> 
> >     this._panel.hidden = false;
> >+    this._panel.setAttribute("height", this._panel.getBoundingClientRect().height);
> 
> >+    this._panel.removeAttribute("height");
> >+    this._textbox.value = "";
> 
> Why are you using the "height" attribute. Don't we use style.height for other
> things? or _panel.height =

No reason, I've correct that in the patch.

Comment 5

[Aakash Desai [:aakashd]]

This one as well due to bug 581097

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre)  Namoroka/4.0b3pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Namoroka/4.0b3pre Fennec/2.0a1pre

Comment 7

[Aakash Desai [:aakashd]]

litmus testcases created:

https://litmus.mozilla.org/show_test.cgi?id=12588
https://litmus.mozilla.org/show_test.cgi?id=12589