Closed Bug 580242 Opened 10 years ago Closed 9 years ago

Add a filter textbox in the select helper UI

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

(Whiteboard: formfill)

Attachments

(1 file)

Attached patch PatchSplinter Review
This patch add a textbox of type search to filter the result of the select helper UI when it is embedded in the form helper
Looks pretty nice
Comment on attachment 458658 [details] [diff] [review]
Patch

>diff -r 2a3e2d9bb723 chrome/content/browser-ui.js

>     this._panel.hidden = false;
>+    this._panel.setAttribute("height", this._panel.getBoundingClientRect().height);

>+    this._panel.removeAttribute("height");
>+    this._textbox.value = "";

Why are you using the "height" attribute. Don't we use style.height for other things? or _panel.height =
Attachment #458658 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/64dbbd01058d(In reply to comment #3)

> Comment on attachment 458658 [details] [diff] [review]
> Patch
> 
> >diff -r 2a3e2d9bb723 chrome/content/browser-ui.js
> 
> >     this._panel.hidden = false;
> >+    this._panel.setAttribute("height", this._panel.getBoundingClientRect().height);
> 
> >+    this._panel.removeAttribute("height");
> >+    this._textbox.value = "";
> 
> Why are you using the "height" attribute. Don't we use style.height for other
> things? or _panel.height =

No reason, I've correct that in the patch.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This one as well due to bug 581097
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 10 years ago9 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre)  Namoroka/4.0b3pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Namoroka/4.0b3pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.