Closed
Bug 580257
Opened 15 years ago
Closed 15 years ago
_getScrollableElements needs to exclude non-scrollable elements
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla2.0b3
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(2 files)
|
2.38 KB,
patch
|
enndeakin
:
review+
|
Details | Diff | Splinter Review |
|
6.39 KB,
patch
|
joe
:
approval2.0+
|
Details | Diff | Splinter Review |
The name "_getScrollableElements" nicely suggests it already: The callers really want /scrollable/ elements which they can iterate over in order to determine scroll targets, etc.
For instance, _elementFromPoint and _distanceScroll currently fail to do something useful when encountering non-scrollable elements.
Attachment #458667 -
Flags: review?(enndeakin)
|
||
Updated•15 years ago
|
Attachment #458667 -
Flags: review?(enndeakin) → review+
|
Assignee | |
Updated•15 years ago
|
Attachment #458667 -
Flags: approval2.0?
|
||
Comment 1•15 years ago
|
||
Comment on attachment 458667 [details] [diff] [review]
patch
No tests?
Attachment #458667 -
Flags: approval2.0?
|
|
Assignee | |
Updated•15 years ago
|
blocking2.0: --- → ?
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #459397 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #459397 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•15 years ago
|
blocking2.0: ? → -
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/06a37463c15e
browser_overflowScroll.js started failing on Linux, although it works perfectly fine locally. I disabled it for now on Linux:
http://hg.mozilla.org/mozilla-central/rev/cf5f013caa80
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•