580323 - Fix up autocomplete-history-popup menuitem in mac classic

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Toolkit changes have regressed the autocomplete menuitem. The height have vanished and the negative margin is not needed anymore (that's good, though).

Comment 1

[Stefan [:stefanh]]

Attachment: Fix menuitem

Comment 2

[[e-mail]]

Comment on attachment 458729 [details] [diff] [review]
Fix menuitem

Why the padding change? (Why the padding override?)

Comment 3

[Stefan [:stefanh]]

We override the padding in menu.css but http://hg.mozilla.org/mozilla-central/diff/9b4420523d0c/toolkit/themes/pinstripe/global/menu.css changed the padding and removed the min-height:

   1.144 @@ -147,9 +164,7 @@ menupopup > menu,
   1.145  popup > menu,
   1.146  menupopup > menuitem,
   1.147  popup > menuitem {
   1.148 -  padding: 0px 3px 2px 3px !important;
   1.149    max-width: 42em;
   1.150 -  min-height: 19px;
   1.151  }

Instead of adding the min-height, I added some padding to compensate for the loss of height. Hm, but I guess I could add the min-height. Then it would look exactly the same as before. Ideally, I would like both (autocomplete and history) widgets look the same.

Comment 4

[Stefan [:stefanh]]

I'll land this on sunday/monday.

Comment 5

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/91bcc6c375cd