Fix up autocomplete-history-popup menuitem in mac classic

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1a3
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

854 bytes, patch
Karsten Düsterloh
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Toolkit changes have regressed the autocomplete menuitem. The height have vanished and the negative margin is not needed anymore (that's good, though).
(Assignee)

Comment 1

7 years ago
Created attachment 458729 [details] [diff] [review]
Fix menuitem
Attachment #458729 - Flags: superreview?(neil)
Attachment #458729 - Flags: review?(mnyromyr)
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED

Comment 2

7 years ago
Comment on attachment 458729 [details] [diff] [review]
Fix menuitem

Why the padding change? (Why the padding override?)
(Assignee)

Comment 3

7 years ago
We override the padding in menu.css but http://hg.mozilla.org/mozilla-central/diff/9b4420523d0c/toolkit/themes/pinstripe/global/menu.css changed the padding and removed the min-height:

   1.144 @@ -147,9 +164,7 @@ menupopup > menu,
   1.145  popup > menu,
   1.146  menupopup > menuitem,
   1.147  popup > menuitem {
   1.148 -  padding: 0px 3px 2px 3px !important;
   1.149    max-width: 42em;
   1.150 -  min-height: 19px;
   1.151  }

Instead of adding the min-height, I added some padding to compensate for the loss of height. Hm, but I guess I could add the min-height. Then it would look exactly the same as before. Ideally, I would like both (autocomplete and history) widgets look the same.

Updated

7 years ago
Attachment #458729 - Flags: superreview?(neil) → superreview+

Updated

7 years ago
Attachment #458729 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 4

7 years ago
I'll land this on sunday/monday.
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/comm-central/rev/91bcc6c375cd
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.