580360 - aboutRedirector broken - about pages like privatebrowsing, sessionrestore, robots all busted

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently on the latest trunk nightly, about:privatebrowsing has been removed and thus when entering PB mode, an alert pops up with 'The URL is not valid and cannot be loaded'.

STR: Enter PB mode

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b2pre) Gecko/20100720 Minefield/4.0b2pre

Comment 1

[Johnathan Nightingale [:johnath]]

Confirmed for me on a nightly build, though gavin isn't seeing it on his own (up to date) build. Packaging issue?

Comment 2

[Johnathan Nightingale [:johnath]]

chrome://browser/content/aboutPrivateBrowsing.xhtml still works, so it looks like the component is missing?

Comment 3

[Johnathan Nightingale [:johnath]]

about:sessionrestore and about:robots also broken - looks like aboutRedirector is unhappy with us.  :(

Updating summary.

Comment 4

[Johnathan Nightingale [:johnath]]

That means safebrowsing is busted, too. :(

On the other hand, can't reproduce this on Vista - might be mac specific?

Comment 5

[Johnathan Nightingale [:johnath]]

Okay - coarse window:

Works: http://hg.mozilla.org/mozilla-central/rev/6b58d2615145

Doesn't : http://hg.mozilla.org/mozilla-central/rev/737a08309d97

Comment 6

[Johnathan Nightingale [:johnath]]

Gives us a biggish window:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6b58d2615145&tochange=737a08309d97

Gavin's gonna try to bisect.

Comment 7

[Benjamin Smedberg]

This was caused by landing bug 578751, without review even! components/*.dylib refuse to load because @loader_path/libxpcom.dylib isn't present, when it should really be @loader_path/../libxpcom.dylib

We'll need to at least back that out, and perhaps bug 557225.

Comment 8

[Johnathan Nightingale [:johnath]]

Yep, bisecting on tinderbox builds gives us this range:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=274a672f9acf&tochange=0c116ba35956

Who's on the backout?

Comment 9

[Benjamin Smedberg]

I pushed a backout http://hg.mozilla.org/mozilla-central/rev/2a32e764c0ca and a candidate fix for the prior build bustage http://hg.mozilla.org/mozilla-central/rev/f4e545ef44dc

If this fails for any reason, we'll back out bug 557225, I left instructions in a release-drivers thread.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Don't have we tests to make sure that those pages are getting loaded correctly?

Comment 11

[Benjamin Smedberg]

We do, but I think the test suite is setting DYLD_LIBRARY_PATH in the environment, which isn't how it runs out of the bundle, so the testsuite was passing incorrectly.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #11)
> We do, but I think the test suite is setting DYLD_LIBRARY_PATH in the
> environment, which isn't how it runs out of the bundle, so the testsuite was
> passing incorrectly.

Worth fixing/changing the test so that we catch this sort of thing in the future?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b3pre) Gecko/20100721 Minefield/4.0b3pre