Closed Bug 580374 Opened 10 years ago Closed 4 years ago

Async visits could be handled after a sync API that removes pages (like clearHistory)

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mak, Unassigned)

References

Details

(Keywords: privacy, regression)

Since clearHistory removes pages synchronously (but visits async), and visits addition is now async, if we quickly add a visit and immediately call clear history, it can end up being registered after clear history.

This is rarely a problem in real usage since users are not so fast, but the issue is visible in tests. Similar issues could be visible with RemoveVisitsXXX and RemovePagesXXX APIs.
We need either to find a way to kill related tasks in adding visits or to make all pages removals APIS async.
Blocks: 575132
hm, where in the async api bug dependency tree should this be?
No longer blocks: 560198
Depends on: 834545
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.