580379 - Move and improve CSS introduced in Bug 558287

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ben Parr [:bparr]]

The CSS introduced by the landed patch for Bug 558287 should be located in content instead of skin. The CSS can also be made simpler.

Comment 1

[Ben Parr [:bparr]]

Attachment: Patch

Moved the necessary code from skin to content. Didn't change the "header-searching" CSS because the throbber's visibility needs to be hidden when not active. That way, the search box doesn't shift back and forth when searching. Also, improved the test to better check the state for the "header-searching" element.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 458786 [details] [diff] [review]
Patch

Looks good however the rule to hide #header-searching should also be in content.

Comment 3

[Ben Parr [:bparr]]

Attachment: Patch v2

Made Dave's change.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 458814 [details] [diff] [review]
Patch v2

>diff --git a/toolkit/mozapps/extensions/test/browser/browser_searching.js b/toolkit/mozapps/extensions/test/browser/browser_searching.js
>--- a/toolkit/mozapps/extensions/test/browser/browser_searching.js
>+++ b/toolkit/mozapps/extensions/test/browser/browser_searching.js
>@@ -86,16 +86,32 @@ function end_test() {
> 
> function getAnonymousElementByAttribute(aElement, aName, aValue) {
>   return gManagerWindow.document.getAnonymousElementByAttribute(aElement,
>                                                                 aName,
>                                                                 aValue);
> }
> 
> /*
>+ * Checks wheter or not the Add-ons Manager is currently searching

*whether

Comment 5

[Ben Parr [:bparr]]

Attachment: Patch v3

Fix typo.

Comment 6

[Alfred Kayser]

Thanks, patch looks good (r=me, if you need it)

Comment 7

[Robert Strong (they/them - no direct email)]

Needs a toolkit peer r+ but I'm sure Dave will get to this shortly

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 458868 [details] [diff] [review]
Patch v3

Yep this looks good, will land when I get to the office.

Comment 9

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/f6c676a1fbba

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed based on check-in and passing tests.