The default bug view has changed. See this FAQ.

Update Comment on mimeTypeIsTextBased to Include Request to Update findbar.xml Upon Any Changes

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
Find In Page
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ben Frisch, Assigned: Ben Frisch)

Tracking

Trunk
seamonkey2.1a3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

963 bytes, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Follow-up bug from bug 97023 comment 51 where Philip Chee wrote:
> In Firefox there is this comment:
> 
> /**
>  * Returns true if |aMimeType| is text-based, false otherwise.
>  *
>  * @param aMimeType
>  *        The MIME type to check.
>  *
>  * If adding types to this function, please also check the similar
>  * function in findbar.xml
>  */
> function mimeTypeIsTextBased(aMimeType)
> 
> Perhaps we should add a similar comment to our implementation of
> mimeTypeIsTextBased()
(Assignee)

Comment 1

7 years ago
Created attachment 458911 [details] [diff] [review]
Add the Comment v.1

This patch should add an appropriate comment.
Assignee: nobody → bfrisch
Status: NEW → ASSIGNED
Attachment #458911 - Flags: review?(neil)

Comment 2

7 years ago
Comment on attachment 458911 [details] [diff] [review]
Add the Comment v.1

>+ * If adding types to this function, please also check the similar
>+ * functions in suite/commom/bindings/findbar.xml and
suite/commom/bindings/findbar.xml just inherits the toolkit version, it doesn't have its own function.

>+ * mozilla/toolkit/widgets/findbar.xml.
Did you mean mozilla/toolkit/content/widgets/findbar.xml?
(Assignee)

Comment 3

7 years ago
Created attachment 459776 [details] [diff] [review]
Add the Comment v.2

This fixed the wrong path to findbar.xml in the toolkit.  It also gets rid of the reference to the findbar.xml in suite, as now that I think about it, we probably shouldn't have a need to update the function in just the suite findbar.xml in the future.

Thanks.
Attachment #458911 - Attachment is obsolete: true
Attachment #459776 - Flags: review?(neil)
Attachment #458911 - Flags: review?(neil)

Updated

7 years ago
Attachment #459776 - Flags: review?(neil) → review+

Comment 4

7 years ago
Pushed changeset 12adef298038 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a3
You need to log in before you can comment on or make changes to this bug.