Follow-up bug from bug 97023 comment 51 where Philip Chee wrote: > In Firefox there is this comment: > > /** > * Returns true if |aMimeType| is text-based, false otherwise. > * > * @param aMimeType > * The MIME type to check. > * > * If adding types to this function, please also check the similar > * function in findbar.xml > */ > function mimeTypeIsTextBased(aMimeType) > > Perhaps we should add a similar comment to our implementation of > mimeTypeIsTextBased()
Created attachment 458911 [details] [diff] [review] Add the Comment v.1 This patch should add an appropriate comment.
Assignee: nobody → bfrisch
Status: NEW → ASSIGNED
Attachment #458911 - Flags: review?(neil)
Comment on attachment 458911 [details] [diff] [review] Add the Comment v.1 >+ * If adding types to this function, please also check the similar >+ * functions in suite/commom/bindings/findbar.xml and suite/commom/bindings/findbar.xml just inherits the toolkit version, it doesn't have its own function. >+ * mozilla/toolkit/widgets/findbar.xml. Did you mean mozilla/toolkit/content/widgets/findbar.xml?
Created attachment 459776 [details] [diff] [review] Add the Comment v.2 This fixed the wrong path to findbar.xml in the toolkit. It also gets rid of the reference to the findbar.xml in suite, as now that I think about it, we probably shouldn't have a need to update the function in just the suite findbar.xml in the future. Thanks.
Pushed changeset 12adef298038 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.