Closed Bug 580598 Opened 14 years ago Closed 14 years ago

Add pluginGlue.js and plugin-container files to removed-files.in

Categories

(Firefox Build System :: General, defect, P2)

defect

Tracking

(blocking2.0 beta3+)

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta3+

People

(Reporter: rail, Assigned: nthomas)

Details

Attachments

(1 file)

During update verification for 4.0b2 I found the following warnings:

* linux, linux64: Only in source/firefox/components: pluginGlue.js
* macosx, macosx64:
** Only in source/Firefox.app/Contents/MacOS/components: pluginGlue.js
** Only in source/Firefox.app/Contents/MacOS: plugin-container
* win32: Only in source/bin/components: pluginGlue.js

Where source/ is the copy of 4.0b1 updated to 4.0b2 compared against an unpacked copy of 4.0b2.

Looks like pluginGlue.js was removed from m-c by http://hg.mozilla.org/mozilla-central/rev/90afd1e80d77 (bug 557225), but not added to removed-files.in.
Assignee: nobody → nrthomas
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P2
Hardware: x86_64 → All
The second hunk is #ifdef XP_MACOSX. There's an implicit approval2.0? on this too.
Attachment #459174 - Flags: review?(ted.mielczarek)
blocking2.0: --- → beta3+
Comment on attachment 459174 [details] [diff] [review]
Remove obsolete plugin files on complete update

I wish this patch had more context, but it makes more sense after actually reading your comment.
Attachment #459174 - Flags: review?(ted.mielczarek) → review+
We can haz checkin?
I'll grab this when I push tonight.
http://hg.mozilla.org/mozilla-central/rev/ee8225c2ae3c
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.