580664 - The default theme isn't selected when it has been detected as changed and the selected theme has become incompatible

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Josh Tumath]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.2.7) Gecko/20100713 Firefox/3.6.7
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.2.7) Gecko/20100713 Firefox/3.6.7

The theme in the "Stratum Fusion" family of add-ons (see URL) is used in trunk builds even though it is not compatible.

Apparently, this is unrelated to bug 565064.

Reproducible: Always

Comment 1

[Dave Townsend [:mossop]]

What are the steps to reproduce this?

Comment 2

[Josh Tumath]

1. Install the group of add-ons in Firefox 3.6.
2. Close Firefox 3.6 and open Minefield.

Comment 3

[Dave Townsend [:mossop]]

I followed those steps and after starting Minefield the default theme was in use and Stratum Fusion correctly showed as incompatible in the add-ons manager.

Do you have the add-on compatibility reporter installed or have you set any of the extensions.checkCompatibility preferences at all?

Comment 4

[Josh Tumath]

I'm not using the compatibility reporter, no. I haven't set those preferences either.

This has been reproduced by Henrik. See bug 565064 comment 28.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Correct. The patch on bug 565064 never fixed this problem we have here. Eventually it's a combination of the theme and extension. I will attach a sample profile I have created on OS X with steps to reproduce.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: test profile

With this test profile do the following steps:

1. Extract it into an existing or newly created profile
2. Start directly a Minefield build

With step 2 you will see that the theme doesn't get disabled even it is incompatible.

Comment 7

[Dave Townsend [:mossop]]

(In reply to comment #6)
> Created attachment 459108 [details]
> test profile
> 
> With this test profile do the following steps:
> 
> 1. Extract it into an existing or newly created profile
> 2. Start directly a Minefield build

What do you see logged to the console when you do this?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Complete output to the console:

*** LOG addons.xpi: startup
*** LOG addons.xpi: Skipping unavailable install location app-system-share
*** LOG addons.xpi: checkForChanges
*** LOG addons.xpi: New add-on Stratum@SoapySpew installed in app-profile
*** LOG addons.xpi: New add-on StratumBuddy@SoapySpew installed in app-profile
*** LOG addons.xpi: Add-on {972ce4c6-7e08-4474-a285-3208198ce6fd} modified in app-global
*** LOG addons.xpi: Activating default theme
*** LOG addons.xpi: Updating database with changes to installed add-ons
*** LOG addons.xpi: Updating add-on states
*** LOG addons.xpi: Writing add-ons list
*** LOG addons.xpi: shutdown

Comment 9

[Dave Townsend [:mossop]]

So from what I can tell you would have to take something like the following steps to reproduce this:

1. Run Minefield on a profile.
2. Run 3.6 on the same profile, install the theme and active it.
3. Run a different version of Minefield (even a different nightly would probably work) on the same profile.

Comment 10

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.