Closed
Bug 580676
Opened 15 years ago
Closed 15 years ago
Add content prefs service service to Services.jsm
Categories
(Core :: General, enhancement)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla2.0b3
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(1 file)
|
1.96 KB,
patch
|
Gavin
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
nsIContentPrefService could be added to Services.jsm
Attachment #459057 -
Flags: review?(gavin.sharp)
Attachment #459057 -
Flags: approval2.0?
|
||
Updated•15 years ago
|
Attachment #459057 -
Flags: review?(gavin.sharp) → review+
|
||
Comment 1•15 years ago
|
||
Shouldn't you use defineLazyServiceGetter instead of defineLazyGetter here?
|
||
Comment 2•15 years ago
|
||
Comment on attachment 459057 [details] [diff] [review]
Patch v0.1
a=beltzner
Attachment #459057 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 3•15 years ago
|
||
(In reply to comment #1)
> Shouldn't you use defineLazyServiceGetter instead of defineLazyGetter here?
Oh, I guess so. Should be grouped with those too. Vivien: can you make that change when checking in?
|
Assignee | |
Comment 4•15 years ago
|
||
(In reply to comment #3)
> (In reply to comment #1)
> > Shouldn't you use defineLazyServiceGetter instead of defineLazyGetter here?
>
> Oh, I guess so. Should be grouped with those too. Vivien: can you make that
> change when checking in?
Sure, I will do.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Assignee: nobody → 21
Target Milestone: --- → mozilla2.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•