580744 - mozmill --report should optionally go to a file

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

Attachment: patch to allow mozmill --report to use file:// URLs and - for stdout

Especially for debugging behaviour with the report "module", though other use-cases can be envisioned, the --report command line option should optionally be able to report to a file.

The attached patch does this for file URLs  (e.g. file:///path/to/file) and for stdout (`mozmill --report -`, per the usual unix convention).  Alternatively, the URL can be seen if it starts with 'http://' or 'https://' and otherwise treat it as a file.  I'm fine with the file:// convention in this case since its not the common usecase (although i don't care much).

This would make fixing + testing bug 579791 much easier.

Comment 1

[cmtalbert]

Going to take this for 1.4.2.  I'm pretty sure that anything making it easier to debug and figure out what is happening is right up Henrik's alley.

Comment 2

[cmtalbert]

Comment on attachment 459113 [details] [diff] [review]
patch to allow mozmill --report to use file:// URLs and - for stdout

Let's just call the stdout option --report=stdout. Otherwise, looks great.  Thanks!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So what's the difference to --logfile? We only put the JSON object in the report saved to disk? that would be even good for my extension.

Comment 4

[Jeff Hammel]

(In reply to comment #3)
> So what's the difference to --logfile? We only put the JSON object in the
> report saved to disk? that would be even good for my extension.

That is correct;  the JSON is output to disk or stdout.  Right now, we don't have a --quiet mode, but conceivably if we added one (that is, we don't output anything by default) then 

mozmill --report=stdout --quiet should just output the report's JSON

Comment 5

[Jeff Hammel]

pushed:

http://github.com/mozautomation/mozmill/commit/8b07ee9b44b46fcd28f55c7b1ab674f6e00f3f4c

http://github.com/mozautomation/mozmill/commit/0ae68256bc1cf0b2d3a3f63859e1182164fc7ffe

I also messed up and forgot to correct the --report=stdout vs --report=- , so I had an additional push on master:

http://github.com/mozautomation/mozmill/commit/6e4114157c989e6a41b2b69310343e21ad8fe1f7

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks good, even the file:// usage is a bit uncommon for command line scripts.

Verified fixed with latest 1.4.2 dev version.