Closed
Bug 580779
Opened 14 years ago
Closed 14 years ago
Gtk-WARNING **: gtkwidget.c:9567: widget class `GtkMenuBar' has no property named `window-dragging'
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b4
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: karlt, Assigned: glandium)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.53 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
Bug added 566480 gtk_widget_style_get for this non-standard property. http://cvs.fedoraproject.org/viewvc/rpms/gtk2/devel/window-dragging.patch?revision=1.1&view=markup&sortby=date That call is not safe with its varargs unless the type is known, which it is not for non-standard properties. We need gtk_widget_class_find_style_property(), and either confirm that it is boolean or use gtk_widget_style_get_property().
|
Reporter | |
Comment 1•14 years ago
|
||
Suggest blocking2.0 mostly because it looks bad on us to spit out these bad-code warnings on launch, but there are also memory safety issues here.
blocking2.0: --- → ?
Hardware: x86_64 → All
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
||
Updated•14 years ago
|
Assignee: nobody → karlt
|
Assignee | |
Comment 2•14 years ago
|
||
> We need gtk_widget_class_find_style_property(), and either confirm
> that it is boolean or use gtk_widget_style_get_property().
gtk_widget_style_get_property still issues a warning, so I went the gtk_widget_class_find_style_property way.Assignee: karlt → mh+mozilla
Attachment #463445 -
Flags: review?(roc)
Attachment #463445 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c6f7936a6956
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in
before you can comment on or make changes to this bug.
Description
•