580789 - unable to cycle through open windows reliably

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[juan becerra [:juanb]]

While testing Fx 4b2, I usually use Command-` on OS X to cycle through the open windows. But I've noticed that's become unreliable. For example, if i go to npr.org and then open one of the audio streams (which opens in a new window), I can't reliably switch windows using that keyboard combination.

I might be able to switch once, but then it won't react to it. Compare that to the latest 3.6x where I have no problems switching windows.

Comment 1

[juan becerra [:juanb]]

By switching windows, I mean switching or cycling through open Firefox windows.

Comment 2

[Benjamin Smedberg]

Since this happens with plugins, was going to say this was caused by OOPP, but since OOPP on mac uses windowless plugins, that doesn't actually make a lot of sense. benwa/josh, any thoughts?

Comment 3

[Benoit Girard (:BenWa)]

I just tried to reproduce the issue but was unable. Here are my steps and configuration, can you verify any differences:

Steps:
1) Navigate to npr.org
2) Select 'Listen' top right.
3) Select 'Talk of Nation' stream
4) New window appears, advertisement plays, audio stream begins.
5) Cycle through windows with CTRL+` in correct order several times.
6) Re-open browser, open several windows and repeat step 1-5.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b2) Gecko/20100720 Firefox/4.0b2

File: Flash Player.plugin
Version: 10.1.53.64
Shockwave Flash 10.1 r53

Comment 4

[Dietrich Ayala (:dietrich)]

Juan, are you still able to reproduce this? Need more input in order to determine whether this blocks.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

--> Core::Plugins

I can confirm this. Looks like the player is eating the keyboard events. I think that's a duplicate bug, Limi might know as he was complaining to me about this before.

Comment 6

[Benoit Girard (:BenWa)]

(In reply to comment #5) 
> I can confirm this. Looks like the player is eating the keyboard events.

You're right, plug-in consume events that it shouldn't. I didn't focus Flash when reproducing the bug the first time so I missed the issue.

Here's a more general STR:
1) Open firefox, press CMD+N (New window)
2) Open and focus flash on a page (youtube.com for example)
3) Press CMD+` to cycle window.

The event is ignored (consumed by the plug-in).

Josh is working on bug 584965, which should land shortly,  that may be the cause of this problem so I'm tentatively listing it as a dependency.

Also reproducible on 3.6.8:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8

Comment 7

[Benjamin Smedberg]

Beltzner, is this a blocker?

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

I think so, yes. OSX users are pretty tied to their shortcuts, making this a visible UX regression.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

This was supposedly fixed by 584965 - can we have that verified?

Comment 10

[juan becerra [:juanb]]

I am no longer able to reproduce this problem on the latest trunk nightly on Mac, which should have the fix for bug 584965. I tested other keyboard shortcuts as well as mouse scrolling when Flash has focus, and I couldn't see a problem.