Closed Bug 580862 Opened 14 years ago Closed 14 years ago

Init gGlobalContext in GLContextProviderCGL

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: BenWa, Assigned: BenWa)

Details

Attachments

(1 file, 1 obsolete file)

      No description provided.
Attached patch patch v1 (obsolete) — Splinter Review
Assignee: nobody → b56girard
Status: NEW → ASSIGNED
Attachment #459280 - Flags: review?
Attachment #459280 - Flags: review? → review?(vladimir)
Comment on attachment 459280 [details] [diff] [review]
patch v1

Need to fix something first.
Attachment #459280 - Attachment is obsolete: true
Attachment #459280 - Flags: review?(vladimir)
Attached patch patch v2Splinter Review
This patch fixes the crash I am seeing when starting up with accelerated="11".
Attachment #459292 - Flags: review?(vladimir)
Comment on attachment 459292 [details] [diff] [review]
patch v2

Heh, now I understand why you were confused on IRC when I kept saying "in the if block", there isn't an if block in the checked-in version of the code.  I did say I had some local changes :-)

But, don't bother creating a new refptr here -- just call init on gGlobalContext, and if it fails, null it out.
Attachment #459292 - Flags: review?(vladimir) → review+
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/89f5210b5072
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: