580964 - Style toolbarbutton[type="menu"]

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

Give them the right dropmarker image and fix up the text for extensions that display it inside the button, like Feedback/Input.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 459368 [details] [diff] [review]
v1

Please use .toolbarbutton-1 instead of toolbarbutton. We require the toolbarbutton-1 class right now so that items can opt out of the primary toolbarbutton appearance. type="menu-button" is an unfortunate exception right now.

Even if we wanted to change this, we'd want to do it consistently across platforms.

>+toolbar[mode="icons"] toolbarbutton[type="menu"]:not(.bookmark-item) > .toolbarbutton-text {
>+  font: -moz-dialog;
>+  margin-top: 0;
>+  -moz-margin-start: 3px;
>+  -moz-margin-end: 1px;
>+}

The Feedback button is only relevant for betas and doesn't seem to follow a common pattern, so I don't really want this code here. If we are serious about supporting text in toolbarbuttons in icons mode, we should probably provide a class for this.

Comment 2

[Markus Stange [:mstange]]

Attachment: v2

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 477313 [details] [diff] [review]
v2

>+.toolbarbutton-1 > .toolbarbutton-menu-dropmarker,
> .toolbarbutton-1 > .toolbarbutton-menubutton-dropmarker {
>   list-style-image: url(chrome://browser/skin/toolbarbutton-dropmarker.png);
>+}
>+
>+.toolbarbutton-1  > .toolbarbutton-menu-dropmarker {
>+  -moz-margin-end: 1px;
>+}
>+
>+toolbarbutton[type="menu-button"] > .toolbarbutton-menubutton-dropmarker {
>   width: 14px;
>   padding-top: 2px;
>   -moz-border-start: none !important;
> }

Seems like toolbarbutton[type="menu-button"] should be .toolbarbutton-1.

Comment 4

[Markus Stange [:mstange]]

Attachment: v3

Sometimes I feel blind.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 477493 [details] [diff] [review]
v3

>+.toolbarbutton-1  > .toolbarbutton-menu-dropmarker {

redundant space after .toolbarbutton-1

Comment 6

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/207ba2088b65