580982 - Matroska VP8+Vorbis works, only WebM should

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Philip Jägenstedt [:foolip]]

User-Agent:       Opera/9.80 (Windows NT 6.1; U; en) Presto/2.6.30 Version/10.70
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:2.0b1) Gecko/20100630 Firefox/4.0b1

Reported by nzasch at https://groups.google.com/a/webmproject.org/group/webm-discuss/browse_thread/thread/2a44b0ee33b39b13#

Opera has already dropped support for the matroska doctype.

Reproducible: Always

Steps to Reproduce:
1. Visit http://storage.arav.ventuordici.org/test/pippo6.webm
Actual Results:  
Video plays

Expected Results:  
Video shouldn't play

Comment 1

[Matthew Gregan [:kinetik]]

Philip, I assume you haven't had much trouble with YouTube videos still using the "matroska" document type, or the V_MS/VFW/FOURCC codec ID?

Here's the proposed fix for libnestegg: http://github.com/kinetiknz/nestegg/commit/dfc6af19cd9729b32d2cd91a2470eb9ebe9e69bf

Comment 2

[Matthew Gregan [:kinetik]]

Missed a chunk: http://github.com/kinetiknz/nestegg/commit/68a09a227dc8ae18bd490409f804f1b9e90a78df

Comment 3

[Matthew Gregan [:kinetik]]

Nominating for 2.0.  We should make sure this is fixed before 2.0 final, otherwise it will become increasingly difficult to fix it if people are producing invalid files.

Comment 4

[Philip Jägenstedt [:foolip]]

Matthew, I haven't seen any bug reports of playback problems on YouTube in Opera that I've linked back to not handling "matroska" doctype or V_MS/VFW/FOURCC.

Comment 5

[Matthew Gregan [:kinetik]]

Attachment: patch v0

Oops, those libnestegg weren't sufficient.  Here's the rest of the changes: http://github.com/kinetiknz/nestegg/commit/844b8bc7695e2d60ad7bde3fb5105c0b24304640

Attached is a roll-up patch for mozilla-central.  Includes mochitest with copy of seek.webm with matroska doctype.

I wonder if it's worth treating SimpleBlocks (and other Matroska v2 elements) as unknown elements if the doctype version is 2.

Comment 6

[Matthew Gregan [:kinetik]]

http://hg.mozilla.org/mozilla-central/rev/9726125de121