581072 - Timeouts fire too early if suspended and then resumed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 558306.  I switched the sign on the subtraction when suspending timers, so instead of setting a positive delay we set a negative one, and then the timers fire too early, of course.

Fix coming up.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix + test

Comment 3

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/308a5a2782b0

Comment 4

[Boris Zbarsky [:bzbarsky]]

We should probably document the new API added here:

    3.16 +
    3.17 +  /**
    3.18 +   * Suspend/resume timeouts on this window and its descendant windows.
    3.19 +   */
    3.20 +  void suspendTimeouts();
    3.21 +  void resumeTimeouts();

on nsIDOMWindowUtils.

Comment 5

[Eric Shepherd [:sheppy]]

bz, you win bonus points for specifically listing the items that need documenting.

The new methods have been documented:

https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsIDOMWindowUtils

Comment 6

[Boris Zbarsky [:bzbarsky]]

Well, without listing them the bug gave no idea of what the new stuff is, right?  ;)