581151 - make chrome no longer works

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[e-mail]]

make chrome recursively invokes make realchrome. However the realchrome target is now conditional on the existence of a jar.mn file.

Comment 1

[[e-mail]]

Attachment: Possible patch

I also considered moving the NO_DIST_INSTALL ifdef since it's an easier test.

Comment 2

[[e-mail]]

Comment on attachment 459551 [details] [diff] [review]
Possible patch

Actually this fix applies pretty obviously to c-c rules.mk too (with offset).

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 459551 [details] [diff] [review]
Possible patch

rs+ for c-c based on khuey's r+ for m-c.

Comment 4

[[e-mail]]

Pushed changeset b6e2a919b701 to mozilla-central.

Pushed changeset a0e75bd610cf to comm-central.

Comment 5

[[e-mail]]

Comment on attachment 459551 [details] [diff] [review]
Possible patch

Seeking approval for all branches where this trivial build config regression is known to have landed. (Using f? instead of a?Tb3.x because I'm too lazy.)

Comment 6

[LegNeato]

Comment on attachment 459551 [details] [diff] [review]
Possible patch

a=LegNeato for 1.9.2 and 1.9.1

Comment 7

[[e-mail]]

Pushed changeset c3643db869bd to releases/mozilla-1.9.2

Pushed changeset ca834d8c9c54 to releases/mozilla-1.9.1

Comment 8

[[e-mail]]

Pushed changeset 69369e04b3bf to releases/comm-1.9.2

Pushed changeset 823d07f99704 to releases/comm-1.9.1

(I actually got a=Standard8 over IRC a couple of weeks ago)

Comment 9

[Mark Banner (:standard8)]

(In reply to comment #8)
> Pushed changeset 69369e04b3bf to releases/comm-1.9.2

Backed this out in changeset 015dd7372a09 due to complete bustage on 1.9.2.