Closed Bug 581271 Opened 14 years ago Closed 8 months ago

Abolish JS_FRIEND_API

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: gal, Unassigned)

Details

I just fixed a couple horrible API abuses in the code base. A poorly designed internal function become JS_FRIEND, and various places in the tree immediately jumped on it (bug 581264). We have very low review standards for JS_FRIEND. Anyone with a pulse is allowed to make these internal APIs. For JS_PUBLIC we tend to consult with Brendan and there is a serious discussion about API design. I propose that we eliminate all JS_FRIEND hooks from the engine as one of the first tasks post 4.0. If we really need the functionality, we add a proper JS_PUBLIC API for it.
Summary: Abolish JS_FRIEND → Abolish JS_FRIEND_API
Assignee: general → nobody
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.