581467 - warning: comparison between signed and unsigned integer expressions in XPT_ParseVersionString

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Josh Matthews [:jdm]]

xpcom/typelib/xpt/src/xpt_struct.c: In function ‘XPT_ParseVersionString’:
xpcom/typelib/xpt/src/xpt_struct.c:945: warning: comparison between signed and unsigned integer expressions

Comment 1

[Atul Aggarwal]

Attachment: Patch v1 to fix unsigned, signed match

Comment 2

[Josh Matthews [:jdm]]

Kyle, do we use any code in typelib any longer?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, this code is used by Gecko to read XPT files.

Comment 4

[Ed Morley [:emorley]]

In my queue :-)

Comment 5

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4ff7e79b62a9

Comment 6

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/4ff7e79b62a9