Last Comment Bug 581467 - warning: comparison between signed and unsigned integer expressions in XPT_ParseVersionString
: warning: comparison between signed and unsigned integer expressions in XPT_Pa...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Atul Aggarwal
:
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2010-07-23 09:42 PDT by Josh Matthews [:jdm]
Modified: 2011-09-01 01:54 PDT (History)
2 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 to fix unsigned, signed match (908 bytes, patch)
2011-08-31 10:52 PDT, Atul Aggarwal
benjamin: review+
Details | Diff | Splinter Review

Description Josh Matthews [:jdm] 2010-07-23 09:42:08 PDT
xpcom/typelib/xpt/src/xpt_struct.c: In function ‘XPT_ParseVersionString’:
xpcom/typelib/xpt/src/xpt_struct.c:945: warning: comparison between signed and unsigned integer expressions
Comment 1 Atul Aggarwal 2011-08-31 10:52:38 PDT
Created attachment 557240 [details] [diff] [review]
Patch v1 to fix unsigned, signed match
Comment 2 Josh Matthews [:jdm] 2011-08-31 11:54:36 PDT
Kyle, do we use any code in typelib any longer?
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-31 12:08:14 PDT
Yes, this code is used by Gecko to read XPT files.
Comment 4 Ed Morley [:emorley] 2011-08-31 15:15:46 PDT
In my queue :-)
Comment 6 Ed Morley [:emorley] 2011-09-01 01:54:47 PDT
http://hg.mozilla.org/mozilla-central/rev/4ff7e79b62a9

Note You need to log in before you can comment on or make changes to this bug.