Last Comment Bug 581474 - possible uninitialized variable use in nsXPCWrappedJS::GetNewOrUsed
: possible uninitialized variable use in nsXPCWrappedJS::GetNewOrUsed
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla9
Assigned To: Atul Aggarwal
:
Mentors:
Depends on:
Blocks: buildwarning
  Show dependency treegraph
 
Reported: 2010-07-23 09:57 PDT by Josh Matthews [:jdm]
Modified: 2011-09-05 11:44 PDT (History)
2 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 to fix warning (949 bytes, patch)
2011-08-31 13:07 PDT, Atul Aggarwal
mrbkap: review+
Details | Diff | Review

Description Josh Matthews [:jdm] 2010-07-23 09:57:55 PDT
js/src/xpconnect/src/xpcwrappedjs.cpp: In static member function ‘static nsresult nsXPCWrappedJS::GetNewOrUsed(XPCCallContext&, JSObject*, const nsIID&, nsISupports*, nsXPCWrappedJS**)’:
js/src/xpconnect/src/xpcwrappedjs.cpp:307: warning: ‘root’ may be used uninitialized in this function
Comment 1 Atul Aggarwal 2011-08-31 13:07:19 PDT
Created attachment 557288 [details] [diff] [review]
Patch v1 to fix warning

Please note I have not tested this patch. Will do the testing once my unix box build is complete.
Comment 2 Blake Kaplan (:mrbkap) (please use needinfo!) 2011-09-01 20:55:12 PDT
Comment on attachment 557288 [details] [diff] [review]
Patch v1 to fix warning

I look forward to days when GCC actually gets its control flow graph to a point where it doesn't give false positives like this.
Comment 3 Ed Morley [:emorley] 2011-09-04 17:39:08 PDT
In my queue :-)
Comment 5 :Ehsan Akhgari (out sick) 2011-09-05 11:44:07 PDT
http://hg.mozilla.org/mozilla-central/rev/b435b37b32c7

Note You need to log in before you can comment on or make changes to this bug.