possible uninitialized variable use in nsXPCWrappedJS::GetNewOrUsed

RESOLVED FIXED in mozilla9

Status

()

Core
XPConnect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: jdm, Assigned: Atul Aggarwal)

Tracking

(Blocks: 1 bug)

Trunk
mozilla9
x86
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
js/src/xpconnect/src/xpcwrappedjs.cpp: In static member function ‘static nsresult nsXPCWrappedJS::GetNewOrUsed(XPCCallContext&, JSObject*, const nsIID&, nsISupports*, nsXPCWrappedJS**)’:
js/src/xpconnect/src/xpcwrappedjs.cpp:307: warning: ‘root’ may be used uninitialized in this function
(Reporter)

Updated

7 years ago
Whiteboard: [build_warning]

Updated

6 years ago
Blocks: 187528
(Assignee)

Comment 1

6 years ago
Created attachment 557288 [details] [diff] [review]
Patch v1 to fix warning

Please note I have not tested this patch. Will do the testing once my unix box build is complete.
Assignee: nobody → atulagrwl
Status: NEW → ASSIGNED
Attachment #557288 - Flags: review?(mrbkap)
Comment on attachment 557288 [details] [diff] [review]
Patch v1 to fix warning

I look forward to days when GCC actually gets its control flow graph to a point where it doesn't give false positives like this.
Attachment #557288 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 3

6 years ago
In my queue :-)
Keywords: checkin-needed

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/b435b37b32c7
Flags: in-testsuite-
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/b435b37b32c7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.