581474 - possible uninitialized variable use in nsXPCWrappedJS::GetNewOrUsed

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Josh Matthews [:jdm]]

js/src/xpconnect/src/xpcwrappedjs.cpp: In static member function ‘static nsresult nsXPCWrappedJS::GetNewOrUsed(XPCCallContext&, JSObject*, const nsIID&, nsISupports*, nsXPCWrappedJS**)’:
js/src/xpconnect/src/xpcwrappedjs.cpp:307: warning: ‘root’ may be used uninitialized in this function

Comment 1

[Atul Aggarwal]

Attachment: Patch v1 to fix warning

Please note I have not tested this patch. Will do the testing once my unix box build is complete.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 557288 [details] [diff] [review]
Patch v1 to fix warning

I look forward to days when GCC actually gets its control flow graph to a point where it doesn't give false positives like this.

Comment 3

[Ed Morley [:emorley]]

In my queue :-)

Comment 4

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b435b37b32c7

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b435b37b32c7