581483 - Available add-ons doesn't include add-ons that are installed even if they are waiting to be uninstalled

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Windows; Windows NT 5.1; rv:2.0b2) Gecko/20100720 Firefox/4.0b2 (.NET CLR 3.5.30729)

When you start another search on AMO after you switched the panes, the list view of the search pane doesn't list any entries.

Steps:
1. Open the Add-ons Manager
2. Search for "url" in the add-ons manager search bar
3. Select the extension pane
4. Click the search bar and press Return

After step 4 the list box on the search pane is empty. You will have to change the search term before the list box gets populated again.

Comment 1

[Dave Townsend [:mossop]]

This only appears to happen if you switch away from the search category while still waiting for results to come from AMO.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No, it also happens when we already got the search results. I assume that we do not trigger another search on AMO and that's why we jump over updating the list view too.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Other steps to reproduce this bug:

1. Search for 'strata'
2. Install Strate Reloaded
3. Click the Remove button
4. Start another search

After step 4 we only show the undo entry but no search results.

Comment 4

[Dave Townsend [:mossop]]

(In reply to comment #2)
> No, it also happens when we already got the search results. I assume that we do
> not trigger another search on AMO and that's why we jump over updating the list
> view too.

I can't reproduce that case, the AMO search results are showing up just fine the second time.

Comment 5

[Dave Townsend [:mossop]]

(In reply to comment #3)
> Other steps to reproduce this bug:
> 
> 1. Search for 'strata'
> 2. Install Strate Reloaded
> 3. Click the Remove button
> 4. Start another search
> 
> After step 4 we only show the undo entry but no search results.

I tried this by searching for "Tweaks" and installing bugzilla tweaks. When the new search in step 4 is the same "Tweaks" it shows up BUgzilla Tweaks as waiting to be uninstalled (which may be resolved by bug 553494). When I do a different search it displays results fine.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

How have you started the new search? I assume not by focusing the search field and pressing Return?

Comment 7

[Dave Townsend [:mossop]]

(In reply to comment #6)
> How have you started the new search? I assume not by focusing the search field
> and pressing Return?

Yes, by clicking in the search box and pressing return

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See my screen cast which shows all the above mentioned issues:
http://www.screencast.com/users/whimboo/folders/Jing/media/703b3041-f0c9-4f62-9660-ee6c59092fe5

Comment 9

[Dave Townsend [:mossop]]

(In reply to comment #8)
> See my screen cast which shows all the above mentioned issues:
> http://www.screencast.com/users/whimboo/folders/Jing/media/703b3041-f0c9-4f62-9660-ee6c59092fe5

The search there is working, it is showing you the entry for the strata reloaded that you uninstalled and offering to let you undo it. Do you think we shouldn't do that?

Comment 10

[Ben Parr [:bparr]]

I can reproduce the problem described in comment 0. The problem deals with Bug 562899. There are two ways to approach the problem. One way is to update the search list even after the user switches away. This way, if the user re-searches for the same thing, the results come up immediately. The other way is to cancel the search completely. Then, if the user searches for the same thing again, the search will start again. I'm leaning toward the second option because the user switched away for a reason. Both ways are simple fixes.

As for the second problem, everything you show in the screen cast is what I expected. Once Bug 553494 is resolved, the search will always show the Undo item. I assume this is what we want to do, since this UI would affect all restartless add-ons, not just ones recently installed in the search view.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #10)
> As for the second problem, everything you show in the screen cast is what I
> expected. Once Bug 553494 is resolved, the search will always show the Undo
> item. I assume this is what we want to do, since this UI would affect all
> restartless add-ons, not just ones recently installed in the search view.

It's a bit confusing with the current ui. Lets wait how all that stuff works once the theme update has been landed. Until then please don't obey that part of the bug.

Comment 12

[Dave Townsend [:mossop]]

So the bug here is just that we don't list any add-ons on the local system even if they are waiting to be uninstalled. I think that that is the correct behaviour so this is a wontfix.