581568 - fix browser_bookmarks.js to work with e10s

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: e10s and bitrot cleanup for browser_bookmarks.js

a bit of bitrot has crept into this test file, here is a cleanup patch.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 459933 [details] [diff] [review]
e10s and bitrot cleanup for browser_bookmarks.js

Good to see the messageManager used for pageshow :)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/21d4ced24389

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

note, these are broken again, due to bug 581252

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

My bad, I should have seen that during my review. To be forgiven here a patch to fix the breakage.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 460475 [details] [diff] [review]
Patch

>diff -r 21d4ced24389 chrome/tests/browser_bookmarks.js
>     // Need to wait until the page is loaded
>     messageManager.addMessageListener("pageshow",
>-    function() {
>-      if (gCurrentTest._currenttab.browser.currentURI.spec != "about:blank") {
>-        messageManager.removeMessageListener("pageshow", arguments.callee);
>+    function(aMessage) {
>+      if (gCurrentTest._currentTab.browser.currentURI.spec != "about:blank") {
>+        messageManager.removeMessageListener(aMessage.name, arguments.callee);
>         gCurrentTest.onPageReady();

Do we really need this change?

Looks good otherwise. We should file a followup bug to add testing the contextmenu too. I am OK with just getting these tests landed first.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

This patch remove toggleManage everywhere (in such a way that browser_bookmarks.js and browser_bookmarks_star.js pass with success) and remove the unused browser_bookmarks_folder.js

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/199c8b2f7618

Comment 8

[Dão Gottwald [:dao]]

bugspam