missing UngetToken() call when looking for declaration terminator

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: dbaron, Assigned: zwol)

Tracking

({css2})

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

There's a missing UngetToken call in the CSS parser's ParseDeclaration method.  It's present both before and after the refactoring in bug 569719 patch 10.

Simple testcase is:

<!DOCTYPE html>
<style>
p { color: fuchsia ! important {; color: red }
</style>
<p>This should not be red or fuchsia (but it's red).</p>

We should fall into {-matching, but we don't since we didn't call UngetToken() on the { token.
(Assignee)

Updated

8 years ago
Depends on: 569719
(Assignee)

Comment 1

8 years ago
Created attachment 460388 [details] [diff] [review]
patch (depends on bug 569719)

Pretty easy to fix post-569719.  I expanded your test case a little.
Assignee: dbaron → zweinberg
Status: NEW → ASSIGNED
Attachment #460388 - Flags: review?(dbaron)
Comment on attachment 460388 [details] [diff] [review]
patch (depends on bug 569719)

r=dbaron
Attachment #460388 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

8 years ago
Created attachment 462231 [details] [diff] [review]
slightly corrected patch

In the first version of this patch I forgot to add the new test to the appropriate reftest.list.  That's the only change.
Attachment #460388 - Attachment is obsolete: true
Attachment #462231 - Flags: review+
Attachment #462231 - Flags: approval2.0?
Attachment #462231 - Flags: approval2.0? → approval2.0+
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.