Closed
Bug 581579
Opened 15 years ago
Closed 15 years ago
missing UngetToken() call when looking for declaration terminator
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: zwol)
References
Details
(Keywords: css2)
Attachments
(1 file, 1 obsolete file)
|
2.33 KB,
patch
|
zwol
:
review+
dbaron
:
approval2.0+
|
Details | Diff | Splinter Review |
There's a missing UngetToken call in the CSS parser's ParseDeclaration method. It's present both before and after the refactoring in bug 569719 patch 10.
Simple testcase is:
<!DOCTYPE html>
<style>
p { color: fuchsia ! important {; color: red }
</style>
<p>This should not be red or fuchsia (but it's red).</p>
We should fall into {-matching, but we don't since we didn't call UngetToken() on the { token.
|
Assignee | |
Comment 1•15 years ago
|
||
Pretty easy to fix post-569719. I expanded your test case a little.
|
Reporter | |
Comment 2•15 years ago
|
||
Attachment #460388 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
In the first version of this patch I forgot to add the new test to the appropriate reftest.list. That's the only change.
Attachment #460388 -
Attachment is obsolete: true
Attachment #462231 -
Flags: review+
Attachment #462231 -
Flags: approval2.0?
|
|
Reporter | |
Updated•15 years ago
|
Attachment #462231 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•