58159 - audit ConnectToDatabase() calls for shadow database use

Status: RESOLVED WORKSFORME

(Bugzilla :: Bugzilla-General, defect, P2)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Some of the Bugzilla scripts call ConnectToDatabase() when they should be
calling ConnectToDatabase(1) to have it use the shadow database, thus hurting
performance.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Mass reassign of my Bugzilla bugs to endico, as I'm switching groups to work on
mozilla LDAP integration full time.

Comment 2

[Dave Miller [:justdave]]

moving to real milestones...

Comment 3

[Dave Miller [:justdave]]

Hey Myk, this seems to be related to what you were just messing with...

Comment 4

[Jacob Steenhagen]

-> New Bugzilla Product

Comment 5

[Gervase Markham [:gerv]]

Here's my list of potential candidates:

whineatnews.pl:ConnectToDatabase();
showvotes.cgi:ConnectToDatabase();
queryhelp.cgi:ConnectToDatabase();
describecomponents.cgi:ConnectToDatabase();
describekeywords.cgi:ConnectToDatabase();
long_list.cgi:ConnectToDatabase();

It's not exactly going to make much difference. :-(

Gerv

Comment 6

[Dave Miller [:justdave]]

showvotes.cgi should use the main database because you can edit things from that
page.

Comment 7

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 8

[Gervase Markham [:gerv]]

See bug 132808 for describekeywords.cgi

Gerv

Comment 9

[Gervase Markham [:gerv]]

Anything left to do here? 

Gerv

Comment 10

[Gervase Markham [:gerv]]

Resolving.

Gerv

Comment 11

[Dave Miller [:justdave]]

clearing milestone in INVALID/WONTFIX/DUPLICATE/WORKSFORME so they'll show up as
untriaged if they get reopened.