581622 - When a quicksearch includes the "content" field, it is limited to 200 bugs

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Jesse Ruderman]

https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL+comp%3Aparser+crash
200 bugs

https://bugzilla.mozilla.org/buglist.cgi?quicksearch=ALL+comp%3Aparser+summary:crash
327 bugs

Comment 2

[Max Kanat-Alexander]

That's not a duplicate of that bug. That bug was actually about the potential of doing those things. I never intended for it to happen until we resolved the question in that bug (which was pretty much answered "no" by the comments).

Comment 3

[Frédéric Buclin]

All we have to do is to remove the 2nd line of:

elsif ($fulltext) {
    $query .= " " . $dbh->sql_limit(FULLTEXT_BUGLIST_LIMIT);

Or maybe it only makes sense to limit the query to 200 results when using the Simple Search form (as it's only used by newbies). What do you think? In that case, we could replace the condition by:

elsif ($cgi->param('simple_search')) {
    ....

Comment 4

[Max Kanat-Alexander]

I suppose we could just remove the limit entirely, no? I don't think Simple Search is used all that often.

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> I suppose we could just remove the limit entirely, no? I don't think Simple
> Search is used all that often.

But how relevant are bugs above the 200th position? Do we really want to show more bugs than that to those using the Simple Search form?

Comment 6

[Max Kanat-Alexander]

I think it's hard to say. What I *do* know is that we want to make the Simple Search form into a quicksearch box (and then probably just relevance sort it) so they probably should start both behaving the same way.

I think there isn't too much harm in showing people bugs above the 200th position, so we might as well do it, since we're pretty sure that quicksearch people want to see more than 200 bugs.

Comment 7

[Frédéric Buclin]

Attachment: patch, v1

Comment 8

[Max Kanat-Alexander]

Comment on attachment 461949 [details] [diff] [review]
patch, v1

Looks good to me.

Comment 9

[Max Kanat-Alexander]

Bye bye premature optimization! :-)

Comment 10

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7411.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7355.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7150.