Last Comment Bug 581622 - When a quicksearch includes the "content" field, it is limited to 200 bugs
: When a quicksearch includes the "content" field, it is limited to 200 bugs
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Query/Bug List (show other bugs)
: 3.6.1
: All All
: -- major (vote)
: Bugzilla 3.6
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-23 19:03 PDT by Jesse Ruderman
Modified: 2010-08-01 16:23 PDT (History)
2 users (show)
mkanat: approval+
mkanat: approval4.0+
mkanat: approval3.6+
mkanat: blocking3.6.2+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (2.31 KB, patch)
2010-08-01 16:13 PDT, Frédéric Buclin
mkanat: review+
Details | Diff | Review

Comment 1 Frédéric Buclin 2010-07-23 19:09:34 PDT

*** This bug has been marked as a duplicate of bug 503806 ***
Comment 2 Max Kanat-Alexander 2010-07-23 22:45:47 PDT
That's not a duplicate of that bug. That bug was actually about the potential of doing those things. I never intended for it to happen until we resolved the question in that bug (which was pretty much answered "no" by the comments).
Comment 3 Frédéric Buclin 2010-08-01 11:42:41 PDT
All we have to do is to remove the 2nd line of:

elsif ($fulltext) {
    $query .= " " . $dbh->sql_limit(FULLTEXT_BUGLIST_LIMIT);

Or maybe it only makes sense to limit the query to 200 results when using the Simple Search form (as it's only used by newbies). What do you think? In that case, we could replace the condition by:

elsif ($cgi->param('simple_search')) {
    ....
Comment 4 Max Kanat-Alexander 2010-08-01 15:52:57 PDT
I suppose we could just remove the limit entirely, no? I don't think Simple Search is used all that often.
Comment 5 Frédéric Buclin 2010-08-01 15:56:17 PDT
(In reply to comment #4)
> I suppose we could just remove the limit entirely, no? I don't think Simple
> Search is used all that often.

But how relevant are bugs above the 200th position? Do we really want to show more bugs than that to those using the Simple Search form?
Comment 6 Max Kanat-Alexander 2010-08-01 16:03:26 PDT
I think it's hard to say. What I *do* know is that we want to make the Simple Search form into a quicksearch box (and then probably just relevance sort it) so they probably should start both behaving the same way.

I think there isn't too much harm in showing people bugs above the 200th position, so we might as well do it, since we're pretty sure that quicksearch people want to see more than 200 bugs.
Comment 7 Frédéric Buclin 2010-08-01 16:13:23 PDT
Created attachment 461949 [details] [diff] [review]
patch, v1
Comment 8 Max Kanat-Alexander 2010-08-01 16:17:25 PDT
Comment on attachment 461949 [details] [diff] [review]
patch, v1

Looks good to me.
Comment 9 Max Kanat-Alexander 2010-08-01 16:17:44 PDT
Bye bye premature optimization! :-)
Comment 10 Frédéric Buclin 2010-08-01 16:23:01 PDT
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7411.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7355.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7150.

Note You need to log in before you can comment on or make changes to this bug.