Closed Bug 581622 Opened 14 years ago Closed 14 years ago

When a quicksearch includes the "content" field, it is limited to 200 bugs

Categories

(Bugzilla :: Query/Bug List, defect)

3.6.1
defect
Not set
major

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: jruderman, Assigned: LpSolit)

Details

Attachments

(1 file)

Flags: blocking3.6.2+
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 3.6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Target Milestone: Bugzilla 3.6 → ---
That's not a duplicate of that bug. That bug was actually about the potential of doing those things. I never intended for it to happen until we resolved the question in that bug (which was pretty much answered "no" by the comments).
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Target Milestone: --- → Bugzilla 3.6
All we have to do is to remove the 2nd line of:

elsif ($fulltext) {
    $query .= " " . $dbh->sql_limit(FULLTEXT_BUGLIST_LIMIT);

Or maybe it only makes sense to limit the query to 200 results when using the Simple Search form (as it's only used by newbies). What do you think? In that case, we could replace the condition by:

elsif ($cgi->param('simple_search')) {
    ....
Status: REOPENED → NEW
Version: unspecified → 3.6.1
I suppose we could just remove the limit entirely, no? I don't think Simple Search is used all that often.
(In reply to comment #4)
> I suppose we could just remove the limit entirely, no? I don't think Simple
> Search is used all that often.

But how relevant are bugs above the 200th position? Do we really want to show more bugs than that to those using the Simple Search form?
I think it's hard to say. What I *do* know is that we want to make the Simple Search form into a quicksearch box (and then probably just relevance sort it) so they probably should start both behaving the same way.

I think there isn't too much harm in showing people bugs above the 200th position, so we might as well do it, since we're pretty sure that quicksearch people want to see more than 200 bugs.
Attached patch patch, v1Splinter Review
Assignee: query-and-buglist → LpSolit
Status: NEW → ASSIGNED
Attachment #461949 - Flags: review?(mkanat)
Comment on attachment 461949 [details] [diff] [review]
patch, v1

Looks good to me.
Attachment #461949 - Flags: review?(mkanat) → review+
Bye bye premature optimization! :-)
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7411.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7355.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified buglist.cgi
modified Bugzilla/Constants.pm
modified template/en/default/global/messages.html.tmpl
Committed revision 7150.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.