Closed
Bug 581652
Opened 14 years ago
Closed 14 years ago
Some versions of gcc won't compile nsCharSeparatedTokenizer
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
jst
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
../../dist/include/nsCharSeparatedTokenizer.h:169: error: ‘& nsCRT::IsAsciiSpace’ is not a valid template argument for type ‘PRBool (*)(short unsigned int)’ because function ‘nsCRT::IsAsciiSpace(PRUnichar)’ has not external linkage
|
Assignee | |
Comment 1•14 years ago
|
||
nsCRT::IsAsciiSpace just wraps NS_IsAsciiWhitespace anyway.
Attachment #460017 -
Flags: review?(jst)
|
||
Updated•14 years ago
|
Attachment #460017 -
Flags: review?(jst) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 460017 [details] [diff] [review] Possible patch Seeking approval for this straightforward compilation issue patch.
Attachment #460017 -
Flags: approval2.0?
Assignee: nobody → neil
|
||
Updated•14 years ago
|
Attachment #460017 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed changeset 81525a39fac5 to mozilla-central.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•