Closed Bug 581652 Opened 10 years ago Closed 10 years ago

Some versions of gcc won't compile nsCharSeparatedTokenizer

Categories

(Core :: XPCOM, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

../../dist/include/nsCharSeparatedTokenizer.h:169: error: ‘& nsCRT::IsAsciiSpace’ is not a valid template argument for type ‘PRBool (*)(short unsigned int)’ because function ‘nsCRT::IsAsciiSpace(PRUnichar)’ has not external linkage
Attached patch Possible patchSplinter Review
nsCRT::IsAsciiSpace just wraps NS_IsAsciiWhitespace anyway.
Attachment #460017 - Flags: review?(jst)
Attachment #460017 - Flags: review?(jst) → review+
Comment on attachment 460017 [details] [diff] [review]
Possible patch

Seeking approval for this straightforward compilation issue patch.
Attachment #460017 - Flags: approval2.0?
Attachment #460017 - Flags: approval2.0? → approval2.0+
Pushed changeset 81525a39fac5 to mozilla-central.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.