Async favicons fails on null data

RESOLVED FIXED in mozilla2.0b4

Status

()

Toolkit
Places
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla2.0b4
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
this can happen in some rare condition (when opening same page multiple times). the icon is set by the first call, next ones are firing useless warnings.
(Assignee)

Comment 1

8 years ago
Created attachment 460023 [details] [diff] [review]
patch v1.0
Attachment #460023 - Flags: review?(sdwilsh)
Comment on attachment 460023 [details] [diff] [review]
patch v1.0

r=sdwilsh
Attachment #460023 - Flags: review?(sdwilsh) → review+
(Assignee)

Comment 3

8 years ago
Comment on attachment 460023 [details] [diff] [review]
patch v1.0

needs approval, risk is minimum, just a null check.
Attachment #460023 - Flags: approval2.0?
Comment on attachment 460023 [details] [diff] [review]
patch v1.0

a=beltzner
Attachment #460023 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 5

8 years ago
forgot to close
http://hg.mozilla.org/mozilla-central/rev/92a9a7c997f1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in before you can comment on or make changes to this bug.