Closed Bug 581686 Opened 14 years ago Closed 14 years ago

Page Info tabs aren't drawn correctly

Categories

(SeaMonkey :: Page Info, defect)

Product:
SeaMonkey
Component:
Page Info
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.1a3

People

(Reporter: neil, Assigned: stefanh)

References

Details

(Keywords: fixed-seamonkey2.0.7, regression)

Attachments

(1 file)

Switch orient on pageInfo's windowdragbox
1.43 KB, patch
mnyromyr
: review+
neil
: superreview+
kairo
: approval-seamonkey2.0.7+
Details | Diff | Splinter Review 
Bug 460699 added a <windowdragbox> element around the <tabs> element. Unfortunately a <windowdragbox> defaults to horizontal orient so the <tabs> element does not stretch to the width of the <tabbox> element as it should.

Themes rely on the <tabs> element stretching to the width of the <tabbox> element to be able to draw their lines correctly.

I don't know whether the <windowdragbox> works if other elements cover it.
It works as long as those elements are in the dragTags list here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/WindowDraggingUtils.jsm#51
or if they have mousethrough="always".

Are there any arguments against giving windowdragbox vertical orient?
In the mac version of pageInfo, we're ok as long as the element inside the windowdragbox keeps its centered position.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #460060 - Flags: superreview?(neil)
Attachment #460060 - Flags: review?(mnyromyr)
Attachment #460060 - Flags: superreview?(neil) → superreview+
Attachment #460060 - Flags: review?(mnyromyr) → review+
I'll land this sunday/monday
http://hg.mozilla.org/comm-central/rev/b87db5e1c4ef
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
Attachment #460060 - Flags: approval-seamonkey2.0.7?
Attachment #460060 - Flags: approval-seamonkey2.0.7? → approval-seamonkey2.0.7+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: