Page Info tabs aren't drawn correctly

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
Page Info
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: stefanh)

Tracking

({fixed-seamonkey2.0.7, regression})

Trunk
seamonkey2.1a3
fixed-seamonkey2.0.7, regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Bug 460699 added a <windowdragbox> element around the <tabs> element. Unfortunately a <windowdragbox> defaults to horizontal orient so the <tabs> element does not stretch to the width of the <tabbox> element as it should.

Themes rely on the <tabs> element stretching to the width of the <tabbox> element to be able to draw their lines correctly.

I don't know whether the <windowdragbox> works if other elements cover it.
It works as long as those elements are in the dragTags list here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/WindowDraggingUtils.jsm#51
or if they have mousethrough="always".

Are there any arguments against giving windowdragbox vertical orient?
(Assignee)

Comment 2

7 years ago
Created attachment 460060 [details] [diff] [review]
Switch orient on pageInfo's windowdragbox

In the mac version of pageInfo, we're ok as long as the element inside the windowdragbox keeps its centered position.
Assignee: nobody → stefanh
Status: NEW → ASSIGNED
Attachment #460060 - Flags: superreview?(neil)
Attachment #460060 - Flags: review?(mnyromyr)
(Reporter)

Updated

7 years ago
Attachment #460060 - Flags: superreview?(neil) → superreview+

Updated

7 years ago
Attachment #460060 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 3

7 years ago
I'll land this sunday/monday
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/comm-central/rev/b87db5e1c4ef
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
(Reporter)

Updated

7 years ago
Attachment #460060 - Flags: approval-seamonkey2.0.7?

Updated

7 years ago
Attachment #460060 - Flags: approval-seamonkey2.0.7? → approval-seamonkey2.0.7+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/releases/comm-1.9.1/rev/88bfb3425178
Keywords: fixed-seamonkey2.0.7
You need to log in before you can comment on or make changes to this bug.