Closed Bug 58170 Opened 25 years ago Closed 24 years ago

Remove fixed-sized strings

Categories

(Core :: Security: PSM, enhancement, P4)

1.0 Branch
enhancement

Tracking

()

VERIFIED FIXED

People

(Reporter: BenB, Assigned: ddrinan0264)

References

Details

From mozilla/security/psm/ui/psm_text.properties.in: ;These next three string must be exactly 33 characters long manufacturerID="Netscape Communications Corp " This is failure-prone, because distributiors will want to change that string. Change the source so that it can use the string, no matter what size it has.
The 33 character fixed length is a requirement of the PKCS#11 standard.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Then please fulfill that requirement by filling the string programatically. E.g. (pseudo-code) if (privSlotDescription.Length > 33) privSlotDescription.Length = privSlotDescription.Length.First(33); else privSlotDescription.Length = ' ' * (33 - privSlotDescription.Length);
s/privSlotDescription.Length =/privSlotDescription =/ s/privSlotDescription.Length.First/privSlotDescription.First/
Reassigning to ddrinan.
Assignee: lord → ddrinan
Status: REOPENED → NEW
QA Contact: nitinp → junruh
nsbeta1
Keywords: nsbeta1
*** Bug 53961 has been marked as a duplicate of this bug. ***
From bug 53961: There are sever strings, e.g. in psm_text.properties.in, which hold UI-, even branding-, strings, but are required to have a certain length, with unnecessary slot being filled up with spaces at the end. This is extremely failure-prone. ------- Additional Comments From Ben Bucksch 2000-09-24 09:10 ------- Search for " "\" to find them.
It may be "failure prone", but it isn't broken. We've got a lot more important things to do than to fix code that isn't broken.
Severity: normal → enhancement
Priority: P3 → P4
Marking fixed. This bug appears not to be relevant now that PSM 2.0 is included in the nightly builds.
Status: NEW → RESOLVED
Closed: 25 years ago24 years ago
Resolution: --- → FIXED
Verified.
Status: RESOLVED → VERIFIED
Product: PSM → Core
Version: psm1.4 → 1.0 Branch
You need to log in before you can comment on or make changes to this bug.