581761 - Web of Trust Add-on set to Block crashes Firefox 3.6.8 [@ nsHtml5TreeBuilder::eof() ]

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P5)

Description

[Ron S]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8

I have used the WOT Web of Trust add-on for many years.  I just set it to BLOCK hazardous websites instead of WARN, because I was informed that a setting of 'warn' still loads the hazardous page and simply places a warning message over the page.  After setting WOT to block, and intentionally visiting any page that has a WOT rating of poor, FF immediately crashes.  It happens every time, on every site I visit with a negative rating.  WOT should stop the page from loading and present a warning page, but not crash out of the browser.  Using WOT with IE8 works correctly.  I am using FF 3.6.8, and WOT 2010503.  Very few other add-ons--all common and popular.  My system is Win XP3, all updates installed, everything else common to FF and IE8. Default theme, no other custom settings.

Reproducible: Always

Steps to Reproduce:
1.Load FF 3.6.8
2.Go to Tools-WOT-Settings
3.On the Settings page, go to Warnings.
4.Set to block, not warn, if yellow orange or red rated sites try to load.
5.Save Settings.
6.Go to Google, and search for any site with a marginal (yellow) rating.
7.Click on link
8.FF immediately crashes and files a crash report.
9.Reopen FF
10.The WOT warning page (white page with 4 large orange/red doughnuts) appears for less than a second
11.FF asks to reload page or start a new session.
12.If I select reload page, I'm taken back to the Google search page just prior to the link being clicked.
Actual Results:  
Clicking any WOT poorly-rated link crashes FF after WOT is set to block instead of warn.

Expected Results:  
WOT should block access to page and instead display a warning, then return to previous referring page.

about:buildconfig

Source

Built from http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a93100d87cc9
Build platform
target
i686-pc-mingw32

Build tools
Compiler 	Version 	Compiler flags
cl 	14.00.50727.762 	-TC -nologo -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1
cl 	14.00.50727.762 	-GR- -TP -nologo -Zc:wchar_t- -W3 -Gy -Fdgenerated.pdb -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -GL -wd4624 -wd4952 -O1

Configure arguments
--enable-application=browser --enable-update-channel=release --enable-update-packaging --enable-jemalloc --enable-official-branding --enable-tests

Comment 1

[Ron S]

From Crash Reporter...


Add-ons: {22119944-ED35-4ab1-910B-E619EA06A115}:6.9.98,{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}:1.2.1,{3d7eb24f-2740-49df-8937-200b1cc08f8a}:1.5.13,[e-mail]:2.6.0.2,{B17C1C5A-04B1-11DB-9804-B622A1EF5492}:1.2,{a7c6cf7f-112c-4500-a7ea-39801a327e5f}:1.0.9,{a0d7ccb3-214d-498b-b4aa-0e8fda9a7bf7}:20100503,{972ce4c6-7e08-4474-a285-3208198ce6fd}:3.6.8
BuildID: 20100722155716
CrashTime: 1280036413
EMCheckCompatibility: true
FramePoisonBase: 00000000f0de0000
FramePoisonSize: 65536
InstallTime: 1279930538
ProductName: Firefox
ReleaseChannel: release
SecondsSinceLastCrash: 1846
StartupTime: 1280034573
Theme: classic/1.0
Throttleable: 1
URL: http://www.google.com/url?sa=t&source=web&cd=3&ved=0CCMQtwIwAg&url=http%3A%2F%2Fwww.ebaumsworld.com%2Fvideo%2Fwatch%2F80684941%2F&ei=5M1LTNKeH4XmsQP905RJ&usg=AFQjCNGR4JwVIyhGaldWvjMzJQCtDE8tyQ
Vendor: Mozilla
Version: 3.6.8

This report also contains technical information about the state of the application when it crashed.

Comment 2

[Ron S]

Added crash report with link to marginally offensive website, as rated by WOT. (Amber).  Any site similarly rated would cause the crash noted above.

Comment 3

[Ron S]

More info--returning WOT settings to WARN instead of BLOCK, corrects the error, loads page, then darkens it and presents a WOT warning page over the other.  Also, a WOT yellow drop down ribbon bar appears under the tab bar with similar warning.

Comment 4

[Jo Hermans]

(In reply to comment #1)
> From Crash Reporter...
> 

What is the crash-id ? Look in about:crashes if you don't know it.

Comment 5

[Ron S]

bp-494dafcb-0606-4642-b004-d831c2100724	7/24/2010	10:40 PM
bp-4c7b0150-772c-4d13-8b76-229f62100724	7/24/2010	10:09 PM
bp-5907386f-ae21-410b-9342-fb0362100724	7/24/2010	10:07 PM
bp-30ff67f9-2e60-467f-a042-3e8b72100724	7/24/2010	10:06 PM

Here are several--I'm sure all from the same event type.

Comment 6

[Ron S]

Also, I apologize for the link posted in Comment 1 as part of the crash report--you might want to pull or obscure it.  Its visibility to the GP was unintentional, and it is a site chosen specifically to be offensive and thus flagged 'orange' by WOT users. I needed a test case--sorry :}

Comment 7

[Matthias Versen [:Matti]]

0  	xul.dll  	nsHtml5TreeBuilder::flushCharacters  	 parser/html/nsHtml5TreeBuilder.cpp:3573
1 	xul.dll 	nsHtml5TreeBuilder::eof 	parser/html/nsHtml5TreeBuilder.cpp:426
2 	xul.dll 	nsHtml5Tokenizer::eof 	parser/html/nsHtml5Tokenizer.cpp:3231
3 	xul.dll 	nsHtml5Parser::DidBuildModel 	parser/html/nsHtml5Parser.cpp:763
4 	xul.dll 	nsHtml5Parser::Terminate 	parser/html/nsHtml5Parser.cpp:432
5 	xul.dll 	nsHTMLDocument::StopDocumentLoad 	
6 	xul.dll 	nsDocShell::Stop 	docshell/base/nsDocShell.cpp:3948
7 	xul.dll 	nsDocShell::InternalLoad 	docshell/base/nsDocShell.cpp:8000
8 	xul.dll 	nsPrincipal::Release 	caps/src/nsPrincipal.cpp:163

Comment 8

[Jo Hermans]

Ron, are you using the HTML5 parser (preference html5.enable in about:config changed to true) ? That's still a bit buggy in Firefox 3.6.8. It's disabled by default in 3.6.*, but Firefox 4.0 will have it enabled.

Comment 9

[Ron S]

It was indeed set to true, although I can't for the life of me remember doing anything of the sort.  I just returned it to false.  I'll do a quick WOT test and post results shortly...

Comment 10

[Ron S]

Unbelievable...  That was indeed the cause of the crash.  Edited the about:config and reset html5.enable back to false. Restarted FF.  Went to the WOT Settings page and set to BLOCK on poorly-rated sites, then visited a handful of poorly rated sites.  All 'blocked' successfully with WOT's warning page.

Well (red-faced apology) sorry to have wasted anyone's time.  At least hope this might help future development in some small way.  Thanks for your efforts and a great piece of software...

R.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Ron, you're welcome and no problem!  The version of the HTML5 parser in Gecko 1.9.2 is indeed just a very early stage of the project and has a number of crashers.  We're planning to just disable it altogether so that people won't accidentally run into those like you did.

Comment 12

[Henri Sivonen (:hsivonen)]

Bug 538722 disabled the HTML5 parser on the 1.9.2 branch so that it can't be enabled by flipping a pref.