Closed
Bug 581804
Opened 15 years ago
Closed 15 years ago
vfychain should call PL_ArenaFinish before exit
Categories
(NSS :: Tools, defect)
NSS
Tools
Tracking
(Not tracked)
RESOLVED
FIXED
3.13
People
(Reporter: hanno, Assigned: hanno)
References
Details
Attachments
(1 file, 1 obsolete file)
|
643 bytes,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
According to the doc at
https://developer.mozilla.org/en/NSS_Memory_allocation
applications using nss should call PL_ArenaFinish before exit to avoid allocated arenas to be shown as leaked by debugging tools like valgrind.
Please apply attached patch to do that for vfychain.
|
||
Updated•15 years ago
|
Assignee: nobody → hanno
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → 3.13
|
|
||
Comment 1•15 years ago
|
||
Comment on attachment 460145 [details]
call PL_ArenaFinish in vfychain before exiting
Hanno, thanks a lot for the patch.
Please call PL_ArenaFinish() before PR_Cleanup().
Note: this bug is an instance of bug 430544.
Attachment #460145 -
Flags: review-
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #460145 -
Attachment is obsolete: true
Attachment #460698 -
Flags: review?(wtc)
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 460698 [details] [diff] [review]
vfychain-noleak-v2.diff
r=wtc.
I checked in the patch on the NSS trunk (NSS 3.13).
Checking in vfychain.c;
/cvsroot/mozilla/security/nss/cmd/vfychain/vfychain.c,v <-- vfychain.c
new revision: 1.31; previous revision: 1.30
done
Attachment #460698 -
Flags: review?(wtc) → review+
|
|
||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•