581812 - yacc.py should use hashlib instead of md5 which has been deprecated

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jory A. Pratt [:anarchy]]

Attachment: use hashlib instead of md5 in python import

the md5 python module has been depreciated in favor of haslib. attached patch tested on gentoo.

Comment 1

[Jory A. Pratt [:anarchy]]

reed if you could get this assigned for review would appreciate it buddy.

Comment 2

[Reed Loden [:reed]]

Comment on attachment 460150 [details] [diff] [review]
use hashlib instead of md5 in python import

Shouldn't this also go upstream?

Comment 3

[Benjamin Smedberg]

Comment on attachment 460150 [details] [diff] [review]
use hashlib instead of md5 in python import

This seems to be obviously incorrect, because the call to md5.new() remains. But this is likely also fixed in a newer version of ply (we're using a very old version), so please check and instead let's update that.

Comment 4

[Jory A. Pratt [:anarchy]]

Attachment: ply-3.3-update-mozilla-central

Comment 5

[Benjamin Smedberg]

Comment on attachment 466337 [details] [diff] [review]
ply-3.3-update-mozilla-central

You've run this by tryserver to make sure quickstubs still works?

Comment 6

[Jory A. Pratt [:anarchy]]

(In reply to comment #5)
> Comment on attachment 466337 [details] [diff] [review]
> ply-3.3-update-mozilla-central
> 
> You've run this by tryserver to make sure quickstubs still works?

Sorry Ben I do not know nothing about tryserver or how to use it. Wish I could be more help in that department but I am not.

Comment 7

[Jory A. Pratt [:anarchy]]

(In reply to comment #5)
> Comment on attachment 466337 [details] [diff] [review]
> ply-3.3-update-mozilla-central
> 
> You've run this by tryserver to make sure quickstubs still works?

Okay after a bit of research on the wiki, I see this would require me to have hg access of atleast level 1 which I do not so I can not push to tryserver to test.

Comment 8

[Jory A. Pratt [:anarchy]]

(In reply to comment #5)
> Comment on attachment 466337 [details] [diff] [review]
> ply-3.3-update-mozilla-central
> 
> You've run this by tryserver to make sure quickstubs still works?
tryserver run has completed gree across the board.

author	Jory A. Pratt <[e-mail]>
Sun Aug 29 11:49:00 2010 -0500 (at Sun Aug 29 11:49:00 2010 -0500)
changeset 79841	9e9df4ea4872
parent 79840	5b01dc3371b7
child 79842	794205c1476b
pushlog:	9e9df4ea4872

Comment 9

[Mounir Lamouri (:mounir)]

bsmedberg, can you give a a+ (if appropriate) considering you reviewed the patch?

Comment 10

[Benjamin Smedberg]

Comment on attachment 466337 [details] [diff] [review]
ply-3.3-update-mozilla-central

Risk isn't worth it, wait until after we branch.

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ec0ae3ba3842