Closed Bug 581812 Opened 10 years ago Closed 9 years ago

yacc.py should use hashlib instead of md5 which has been deprecated

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: anarchy, Assigned: anarchy)

Details

Attachments

(1 file, 1 obsolete file)

the md5 python module has been depreciated in favor of haslib. attached patch tested on gentoo.
Attachment #460150 - Attachment is patch: true
Attachment #460150 - Attachment mime type: application/octet-stream → text/plain
reed if you could get this assigned for review would appreciate it buddy.
Assignee: nobody → anarchy
Comment on attachment 460150 [details] [diff] [review]
use hashlib instead of md5 in python import

Shouldn't this also go upstream?
Attachment #460150 - Flags: review?(benjamin)
Comment on attachment 460150 [details] [diff] [review]
use hashlib instead of md5 in python import

This seems to be obviously incorrect, because the call to md5.new() remains. But this is likely also fixed in a newer version of ply (we're using a very old version), so please check and instead let's update that.
Attachment #460150 - Flags: review?(benjamin) → review-
Attachment #460150 - Attachment is obsolete: true
Attachment #466337 - Flags: review?(benjamin)
Comment on attachment 466337 [details] [diff] [review]
ply-3.3-update-mozilla-central

You've run this by tryserver to make sure quickstubs still works?
Attachment #466337 - Flags: review?(benjamin) → review+
(In reply to comment #5)
> Comment on attachment 466337 [details] [diff] [review]
> ply-3.3-update-mozilla-central
> 
> You've run this by tryserver to make sure quickstubs still works?

Sorry Ben I do not know nothing about tryserver or how to use it. Wish I could be more help in that department but I am not.
(In reply to comment #5)
> Comment on attachment 466337 [details] [diff] [review]
> ply-3.3-update-mozilla-central
> 
> You've run this by tryserver to make sure quickstubs still works?

Okay after a bit of research on the wiki, I see this would require me to have hg access of atleast level 1 which I do not so I can not push to tryserver to test.
(In reply to comment #5)
> Comment on attachment 466337 [details] [diff] [review]
> ply-3.3-update-mozilla-central
> 
> You've run this by tryserver to make sure quickstubs still works?
tryserver run has completed gree across the board.

author	Jory A. Pratt <anarchy@gentoo.org>
Sun Aug 29 11:49:00 2010 -0500 (at Sun Aug 29 11:49:00 2010 -0500)
changeset 79841	9e9df4ea4872
parent 79840	5b01dc3371b7
child 79842	794205c1476b
pushlog:	9e9df4ea4872
Attachment #466337 - Flags: approval2.0?
bsmedberg, can you give a a+ (if appropriate) considering you reviewed the patch?
Status: NEW → ASSIGNED
Comment on attachment 466337 [details] [diff] [review]
ply-3.3-update-mozilla-central

Risk isn't worth it, wait until after we branch.
Attachment #466337 - Flags: approval2.0? → approval2.0-
http://hg.mozilla.org/mozilla-central/rev/ec0ae3ba3842
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Summary: yacc.py should use hashlib instead of md5 which has been depreciated → yacc.py should use hashlib instead of md5 which has been deprecated
You need to log in before you can comment on or make changes to this bug.