581863 - gtk/nsWindow::GetScreenBounds returns client window size instead of outer (frame) size

Status: REOPENED

(Core :: Widget: Gtk, defect, P3)

Description

[Karl Tomlinson (:karlt)]

nsIWidget::GetScreenBounds should return the "widget's outside dimensions in global coordinates. This includes any title bar on the window."

Correcting this will make test_screenPersistence.xul at least correctly notice that windows created with outer dimensions have the wrong size.

test_screenPersistance.xul will also fail because it opens a window with (inner, I assume) width/height = 300 and expects outerWidth/outerHeight to be 300.

Comment 1

[Karl Tomlinson (:karlt)]

gdk_window_get_frame_extents is the function to use here.

Comment 2

[Karl Tomlinson (:karlt)]

(In reply to comment #0)
> Correcting this will make test_screenPersistence.xul at least correctly notice
> that windows created with outer dimensions have the wrong size.

Filed Bug 581866.

Comment 3

[Jonathan Watt [:jwatt]]

Closing GTK2 related bugs since we removed GTK2 support at the beginning of 2018 in bug 1278282. Probably best to open a new bug in the unlikely event that any of these are still relevant.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:stransky, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 581863 - Fix nsWindow coordinates to make sense. r=stransky!

I stumbled upon this bug while realizing that some of the math I'm doing
for PiP windows doesn't work at all on Linux (bug 1934760), because
screenX != mozInnerScreenX, even though outerWidth == innerWidth.

I've tested this on X11 and Wayland (plasma and Gnome) with CSD and SSD,
and in general, this is the same thing Windows does, so should be fine.

The basic idea is:

• Keep mBounds being frame manager bounds (so, outer* and screen*),
  relative to mShell.

• Keep mClientMargin to translate from mBounds to client bounds.

This is both simpler and makes the math consistent.